Disable proxy for NTLM authentication (#57)

Jeff Young · bryanmacfarlane · commit 04dc9f53b149 · 2016-10-21T10:45:05.000-04:00
* Allow NTLM handler to disable proxying

* Bump version to 5.1.1
diff --git a/api/handlers/ntlm.ts b/api/handlers/ntlm.ts
@@ -27,6 +27,10 @@ export class NtlmCredentialHandler implements VsoBaseInterfaces.IRequestHandler
 
     prepareRequest(options:any): void {
         // No headers or options need to be set.  We keep the credentials on the handler itself.
+        // If a (proxy) agent is set, remove it as we don't support proxy for NTLM at this time
+        if (options.agent) {
+            delete options.agent;
+        }
     }
 
     canHandleAuthentication(res: VsoBaseInterfaces.IHttpResponse): boolean {
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "vso-node-api",
   "description": "Node client for Visual Studio Online/TFS REST APIs",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "main": "./WebApi.js",
   "typings": "./WebApi.d.ts",
   "scripts": {

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ export class NtlmCredentialHandler implements VsoBaseInterfaces.IRequestHandler`
`27`	`27`
`28`	`28`	`prepareRequest(options:any): void {`
`29`	`29`	`// No headers or options need to be set. We keep the credentials on the handler itself.`
	`30`	`+ // If a (proxy) agent is set, remove it as we don't support proxy for NTLM at this time`
	`31`	`+ if (options.agent) {`
	`32`	`+ delete options.agent;`
	`33`	`+ }`
`30`	`34`	`}`
`31`	`35`
`32`	`36`	`canHandleAuthentication(res: VsoBaseInterfaces.IHttpResponse): boolean {`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "vso-node-api",`
`3`	`3`	`"description": "Node client for Visual Studio Online/TFS REST APIs",`
`4`		`- "version": "5.1.0",`
	`4`	`+ "version": "5.1.1",`
`5`	`5`	`"main": "./WebApi.js",`
`6`	`6`	`"typings": "./WebApi.d.ts",`
`7`	`7`	`"scripts": {`