Merge pull request #704 from mjbvz/RootProject-Homepages-null-deref-fix

Check for null before dereference on RootPackage.HomePages

Author: mousetraps

Nodejs/Product/Nodejs/Project/DependencyNode.cs

@@ -167,11 +167,13 @@ internal override int QueryStatusOnNode(Guid cmdGroup, uint cmd, IntPtr pCmdText
             if (cmdGroup == Guids.NodejsNpmCmdSet) {
                 switch (cmd) {
                     case PkgCmdId.cmdidNpmOpenModuleHomepage:
-                        using (var enumerator = this.Package.Homepages.GetEnumerator()) {
-                            if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
-                                result = QueryStatusResult.ENABLED | QueryStatusResult.SUPPORTED;
-                            } else {
-                                result = QueryStatusResult.SUPPORTED;
+                        if (this.Package.Homepages != null) {
+                            using (var enumerator = this.Package.Homepages.GetEnumerator()) {
+                                if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
+                                    result = QueryStatusResult.ENABLED | QueryStatusResult.SUPPORTED;
+                                } else {
+                                    result = QueryStatusResult.SUPPORTED;
+                                }
                             }
                         }
                         return VSConstants.S_OK;
@@ -225,9 +227,11 @@ internal override int ExecCommandOnNode(Guid cmdGroup, uint cmd, uint nCmdexecop
             if (cmdGroup == Guids.NodejsNpmCmdSet) {
                 switch (cmd) {
                     case PkgCmdId.cmdidNpmOpenModuleHomepage:
-                        using (var enumerator = this.Package.Homepages.GetEnumerator()) {
-                            if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
-                                Process.Start(enumerator.Current);
+                        if (this.Package.Homepages != null) {
+                            using (var enumerator = this.Package.Homepages.GetEnumerator()) {
+                                if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
+                                    Process.Start(enumerator.Current);
+                                }
                             }
                         }
                         return VSConstants.S_OK;