You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -13,20 +13,20 @@ When creating new issues in the issue tracker, please follow these guidelines:
13
13
14
14
15
15
## Submitting a Pull Request
16
-
All pull requests are reviewed by one of the project maintainers before being merged in. Here are some guidelines that to help the process go as quickly as possible:
16
+
In order to help us improve code quality and make NTVS better in general, here are some simple guidelines for pull requests:
17
17
18
18
- Clearly state what the pull request accomplishes.
19
19
- If it's a bug fix, what was the bug and how has it been fixed?
20
-
- If you're adding a new feature, what is it and what does it do for users?
21
-
- Provide a high level explanation of the code changes. This will help reviewers understand your implementation choices and will speed up the review process.
22
-
-Please try to keep pull requests small and focused.
20
+
- If you're adding a new feature, explain the feature and its use cases.
21
+
- Provide a high level explanation of your changes. This will help reviewers understand implementation choices and will speed up the review process.
22
+
-Try to keep pull requests small and focused.
23
23
- Make sure that existing tests continue to pass.
24
24
- All new code must include tests.
25
25
- For a bug fix, consider adding a test that would fail before your change, but passes now.
26
26
- Feel free to ask for advice if you are unsure how what to test or how to integrate into our test infrastructure.
27
27
- There is no formal code style-guide, but please try to match the style of any file you are editing.
28
28
29
-
If you are unsure of anything, feel free to ask a question. We're always happy to help.
29
+
All pull requests are reviewed by one of the project maintainers before being merged in If you are unsure of anything, feel free to ask them question. We're always happy to help.
30
30
31
31
### Licensing and Legal
32
32
Node.js Tools for Visual Studio is a member of [Microsoft](http://microsoft.github.io/) and operates under the [Apache 2.0 license](https://github.com/Microsoft/nodejstools/blob/master/LICENSE).
0 commit comments