Merge pull request #795 from Microsoft/revert-783-jspaser-parse-fix

mousetraps · mousetraps · commit 846c3b8103c8 · 2016-03-30T11:31:09.000-07:00
Revert "Fix potential parse error for large hex numbers"
diff --git a/Nodejs/Product/Analysis/JavaScript/jsparser.cs b/Nodejs/Product/Analysis/JavaScript/jsparser.cs
@@ -3905,13 +3905,7 @@ private bool ConvertNumericLiteralToDouble(string str, bool isInteger, out doubl
                             }
 
                             // parse the number as a hex integer, converted to a double
-                            long hexValue;
-                            if (Int64.TryParse(str.Substring(2), NumberStyles.HexNumber, CultureInfo.InvariantCulture, out hexValue)) {
-                                doubleValue = hexValue;
-                            } else {
-                                doubleValue = 0;
-                                return false;
-                            }
+                            doubleValue = (double)System.Convert.ToInt64(str, 16);
                         }
                         else
                         {

Original file line number	Diff line number	Diff line change
`@@ -3905,13 +3905,7 @@ private bool ConvertNumericLiteralToDouble(string str, bool isInteger, out doubl`
`3905`	`3905`	`}`
`3906`	`3906`
`3907`	`3907`	`// parse the number as a hex integer, converted to a double`
`3908`		`- long hexValue;`
`3909`		`- if (Int64.TryParse(str.Substring(2), NumberStyles.HexNumber, CultureInfo.InvariantCulture, out hexValue)) {`
`3910`		`- doubleValue = hexValue;`
`3911`		`- } else {`
`3912`		`- doubleValue = 0;`
`3913`		`- return false;`
`3914`		`- }`
	`3908`	`+ doubleValue = (double)System.Convert.ToInt64(str, 16);`
`3915`	`3909`	`}`
`3916`	`3910`	`else`
`3917`	`3911`	`{`