Skip to content

Commit a3f9233

Browse files
committed
Merge pull request #720 from mousetraps/signing
#714 update signing certificates
2 parents 9354a1b + 49aab2c commit a3f9233

3 files changed

Lines changed: 19 additions & 9 deletions

File tree

Build/BuildReleaseHelpers.psm1

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,16 @@ function begin_sign_files {
6969
$job.Keywords = $jobKeywords
7070

7171
if ($certificates -match "authenticode") {
72-
$job.SelectCertificate("10006") # Authenticode
72+
$job.SelectCertificate("401") # Authenticode
73+
}
74+
if ($certificates -match "msi") {
75+
$job.SelectCertificate("400") # Authenticode
7376
}
7477
if ($certificates -match "strongname") {
7578
$job.SelectCertificate("67") # StrongName key
7679
}
77-
if ($certificates -match "opc") {
78-
$job.SelectCertificate("160") # Microsoft OPC Publisher (VSIX)
80+
if ($certificates -match "vsix") {
81+
$job.SelectCertificate("10040160") # Microsoft OPC Publisher (VSIX)
7982
}
8083

8184
foreach ($approver in $approvers) {

Build/BuildReleaseMockHelpers.psm1

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,23 @@ job.Keywords: $jobKeywords"
7777

7878
if ($certificates -match "authenticode") {
7979
$msg = "$msg
80-
job.SelectCertificate(10006)"
81-
$job.SelectCertificate("10006") # Authenticode
80+
job.SelectCertificate(401)"
81+
$job.SelectCertificate("401") # Authenticode
82+
}
83+
if ($certificates -match "msi") {
84+
$msg = "$msg
85+
job.SelectCertificate(400)"
86+
$job.SelectCertificate("400") # Authenticode for MSI
8287
}
8388
if ($certificates -match "strongname") {
8489
$msg = "$msg
8590
job.SelectCertificate(67)"
8691
$job.SelectCertificate("67") # StrongName key
8792
}
88-
if ($certificates -match "opc") {
89-
$job.SelectCertificate("160") # Microsoft OPC Publisher (VSIX)
93+
if ($certificates -match "vsix") {
94+
$msg = "$msg
95+
job.SelectCertificate(100040160)"
96+
$job.SelectCertificate("100040160") # Microsoft OPC Publisher (VSIX)
9097
}
9198

9299
foreach ($approver in $approvers) {

Nodejs/Setup/BuildRelease.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ try {
561561

562562
$jobs += begin_sign_files $msi_files $i.signed_msidir $approvers `
563563
$project_name $project_url "$project_name $($i.VSName) - installer" $project_keywords `
564-
"authenticode"
564+
"msi"
565565
}
566566

567567

@@ -575,7 +575,7 @@ try {
575575

576576
$jobs += begin_sign_files $vsix_files $i.signed_msidir $approvers `
577577
$project_name $project_url "$project_name $($i.VSName) - VSIX" $project_keywords `
578-
"authenticode;opc"
578+
"vsix"
579579
}
580580
}
581581

0 commit comments

Comments
 (0)