Skip to content

Commit af12467

Browse files
authored
Merge pull request #1577 from paulvanbrenk/removeLogConverter
Bunch of smaller fixes
2 parents 3e8f255 + 5275144 commit af12467

5 files changed

Lines changed: 7 additions & 14 deletions

File tree

Nodejs/NodejsTools.sln

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
33
# Visual Studio 15
4-
VisualStudioVersion = 15.0.26507.0
4+
VisualStudioVersion = 15.0.26510.0
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Nodejs", "Product\Nodejs\Nodejs.csproj", "{32EC5259-98DA-40CA-9E2D-1B1B2E966F88}"
77
ProjectSection(ProjectDependencies) = postProject
88
{5085DF35-3A32-4894-835E-E5A3956D4F57} = {5085DF35-3A32-4894-835E-E5A3956D4F57}
99
{CB61D8BD-48DC-40F4-A4BA-5B68A10A7481} = {CB61D8BD-48DC-40F4-A4BA-5B68A10A7481}
1010
EndProjectSection
1111
EndProject
12-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LogConverter", "Product\LogConverter\LogConverter.csproj", "{9A69745F-546D-40A0-8770-7E5B9ED0C82F}"
13-
EndProject
1412
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "InteractiveWindow", "Product\InteractiveWindow\InteractiveWindow.csproj", "{24A3887F-DA50-4989-8D6C-4A5B04D5D457}"
1513
EndProject
1614
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Product", "Product", "{F9719B35-F359-47A7-A2F8-34F42E53C809}"
@@ -35,10 +33,6 @@ Global
3533
{32EC5259-98DA-40CA-9E2D-1B1B2E966F88}.Debug|x86.Build.0 = Debug|x86
3634
{32EC5259-98DA-40CA-9E2D-1B1B2E966F88}.Release|x86.ActiveCfg = Release|x86
3735
{32EC5259-98DA-40CA-9E2D-1B1B2E966F88}.Release|x86.Build.0 = Release|x86
38-
{9A69745F-546D-40A0-8770-7E5B9ED0C82F}.Debug|x86.ActiveCfg = Debug|x86
39-
{9A69745F-546D-40A0-8770-7E5B9ED0C82F}.Debug|x86.Build.0 = Debug|x86
40-
{9A69745F-546D-40A0-8770-7E5B9ED0C82F}.Release|x86.ActiveCfg = Release|x86
41-
{9A69745F-546D-40A0-8770-7E5B9ED0C82F}.Release|x86.Build.0 = Release|x86
4236
{24A3887F-DA50-4989-8D6C-4A5B04D5D457}.Debug|x86.ActiveCfg = Debug|x86
4337
{24A3887F-DA50-4989-8D6C-4A5B04D5D457}.Debug|x86.Build.0 = Debug|x86
4438
{24A3887F-DA50-4989-8D6C-4A5B04D5D457}.Release|x86.ActiveCfg = Release|x86
@@ -69,7 +63,6 @@ Global
6963
EndGlobalSection
7064
GlobalSection(NestedProjects) = preSolution
7165
{32EC5259-98DA-40CA-9E2D-1B1B2E966F88} = {F9719B35-F359-47A7-A2F8-34F42E53C809}
72-
{9A69745F-546D-40A0-8770-7E5B9ED0C82F} = {F9719B35-F359-47A7-A2F8-34F42E53C809}
7366
{24A3887F-DA50-4989-8D6C-4A5B04D5D457} = {F9719B35-F359-47A7-A2F8-34F42E53C809}
7467
{DBC73DF7-1B4C-48BE-8B48-715297487E7A} = {F9719B35-F359-47A7-A2F8-34F42E53C809}
7568
{712D84EC-B2A6-46D1-B030-BA697AE5E554} = {F9719B35-F359-47A7-A2F8-34F42E53C809}

Nodejs/Product/Nodejs/Templates/Files/EmptyJson/EmptyJson.vstemplate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<TemplateData>
33
<Name Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3023"/>
44
<Description Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3024"/>
5-
<Icon Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="0"/>
5+
<Icon Package="{AAB75614-2F8F-4DA6-B0A6-763C6DBB2969}" ID="2200"/>
66
<ProjectType>Node.js</ProjectType>
77
<DefaultName>Json.json</DefaultName>
88
<SortOrder>420</SortOrder>

Nodejs/Product/Nodejs/Templates/Files/EmptyLess/EmptyLess.vstemplate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<TemplateData>
33
<Name Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3038"/>
44
<Description Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3039"/>
5-
<Icon Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="0"/>
5+
<Icon Package="{AAB75614-2F8F-4DA6-B0A6-763C6DBB2969}" ID="2100"/>
66
<ProjectType>Node.js</ProjectType>
77
<DefaultName>StyleSheet.less</DefaultName>
88
<SortOrder>450</SortOrder>

Nodejs/Product/Nodejs/Templates/Files/EmptyTs/EmptyTs.vstemplate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<TemplateData>
33
<Name Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3017"/>
44
<Description Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3018"/>
5-
<Icon Package="{FE8A8C3D-328A-476D-99F9-2A24B75F8C7F}" ID="3"/>
5+
<Icon Package="{2ffe45c4-5c73-493c-b187-f2e955ff875e}" ID="3"></Icon>
66
<ProjectType>Node.js</ProjectType>
77
<DefaultName>TypeScript.ts</DefaultName>
88
<SortOrder>200</SortOrder>

Nodejs/Product/Npm/SPI/RootPackage.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System.Collections.Generic;
44
using System.Globalization;
55
using System.IO;
6+
using System.Linq;
67
using Microsoft.CSharp.RuntimeBinder;
78

89
namespace Microsoft.NodejsTools.Npm.SPI
@@ -54,11 +55,11 @@ public RootPackage(
5455

5556
public string Path { get; }
5657

57-
public IEnumerable<string> Homepages => this.PackageJson?.Homepages;
58+
public IEnumerable<string> Homepages => this.PackageJson?.Homepages ?? Enumerable.Empty<string>();
5859

5960
public bool HasPackageJson => this.PackageJson != null;
6061

61-
public string Name => this.HasPackageJson ? new DirectoryInfo(this.Path).Name : this.PackageJson.Name;
62+
public string Name => this.PackageJson?.Name ?? new DirectoryInfo(this.Path).Name;
6263

6364
public SemverVersion Version => this.PackageJson?.Version ?? new SemverVersion();
6465

@@ -67,4 +68,3 @@ public RootPackage(
6768
public string Description => this.PackageJson?.Description;
6869
}
6970
}
70-

0 commit comments

Comments
 (0)