Merge pull request #459 from mousetraps/i208

fix #208 Error reading package.json. The file may be parseable JSON but may

Author: mousetraps

Nodejs/Product/Npm/ReaderPackageJsonSource.cs

@@ -17,12 +17,21 @@
 using System;
 using System.IO;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 
 namespace Microsoft.NodejsTools.Npm {
     public class ReaderPackageJsonSource : IPackageJsonSource {
         public ReaderPackageJsonSource(TextReader reader) {
             try {
-                Package = JsonConvert.DeserializeObject(reader.ReadToEnd());
+                var text = reader.ReadToEnd();
+                try {
+                    // JsonConvert and JObject.Parse exhibit slightly different behavior,
+                    // so fall back to JObject.Parse if JsonConvert does not properly deserialize
+                    // the object.
+                    Package = JsonConvert.DeserializeObject(text);
+                } catch (ArgumentException) {
+                    Package = JObject.Parse(text);
+                }
             } catch (JsonReaderException jre) {
                 WrapExceptionAndRethrow(jre);
             } catch (JsonSerializationException jse) {

Nodejs/Product/Npm/SPI/NodeModules.cs

@@ -46,7 +46,14 @@ public NodeModules(IRootPackage parent, bool showMissingDevOptionalSubPackages,
                 // Go through every directory in node_modules, and see if it's required as a top-level dependency
                 foreach (var moduleDir in topLevelDirectories) {
                     if (moduleDir.Length < NativeMethods.MAX_FOLDER_PATH && !_ignoredDirectories.Any(toIgnore => moduleDir.EndsWith(toIgnore))) {
-                        var packageJson = PackageJsonFactory.Create(new DirectoryPackageJsonSource(moduleDir));
+                        IPackageJson packageJson;
+                        try {
+                            packageJson = PackageJsonFactory.Create(new DirectoryPackageJsonSource(moduleDir));
+                        } catch (PackageJsonException) {
+                            // Fail gracefully if there was an error parsing the package.json
+                            Debug.Fail("Failed to parse package.json in {0}", moduleDir);
+                            continue;
+                        }
 
                         if (packageJson != null) {
                             if (packageJson.RequiredBy.Count() > 0) {