Merge pull request #708 from mjbvz/remove-npm-status-logging

#145 Remove Npm logging to status bar

Author: mousetraps

Nodejs/Product/Nodejs/Project/NodeModulesNode.cs

@@ -217,7 +217,6 @@ private void ConditionallyShowNpmOutputPane() {
         }
 
 #if INTEGRATE_WITH_ERROR_LIST
-
         private ErrorListProvider _errorListProvider;
 
         private ErrorListProvider GetErrorListProvider() {
@@ -301,8 +300,6 @@ private void WriteNpmLogToOutputWindow(string logText) {
                 pane.WriteLine(logText);
             }
 
-            UpdateStatusBarWithNpmActivity(logText);
-
 #if INTEGRATE_WITH_ERROR_LIST
             WriteNpmErrorsToErrorList(args);
 #endif
@@ -339,18 +336,7 @@ private void NpmController_CommandCompleted(object sender, NpmCommandCompletedEv
                 }
             }
 
-            string message;
-            if (e.WithErrors) {
-                message = SR.GetString(
-                    e.Cancelled ? SR.NpmCancelledWithErrors : SR.NpmCompletedWithErrors,
-                    e.CommandText
-                );
-            } else if (e.Cancelled) {
-                message = SR.GetString(SR.NpmCancelled, e.CommandText);
-            } else {
-                message = SR.GetString(SR.NpmSuccessfullyCompleted, e.CommandText);
-            }
-
+            var message = GetStatusBarMessage(e);
             ForceUpdateStatusBarWithNpmActivitySafe(message);
 
             StopNpmIdleTimer();
@@ -359,6 +345,17 @@ private void NpmController_CommandCompleted(object sender, NpmCommandCompletedEv
                 null, 1000, Timeout.Infinite);
         }
 
+        private static string GetStatusBarMessage(NpmCommandCompletedEventArgs e) {
+            if (e.WithErrors) {
+                return SR.GetString(
+                    e.Cancelled ? SR.NpmCancelledWithErrors : SR.NpmCompletedWithErrors,
+                    e.CommandText);
+            } else if (e.Cancelled) {
+                return SR.GetString(SR.NpmCancelled, e.CommandText);
+            }
+            return SR.GetString(SR.NpmSuccessfullyCompleted, e.CommandText);
+        }
+
         private void StopNpmIdleTimer() {
             if (null != _npmIdleTimer) {
                 _npmIdleTimer.Dispose();