Merge pull request #526 from mousetraps/i70

#70 Visual Studio crashes when I quit debugging

Author: mousetraps

Nodejs/Product/Analysis/Analysis/Analyzer/AnalysisUnit.cs

@@ -183,17 +183,20 @@ internal void Analyze(DDG ddg, CancellationToken cancel) {
                 long endTime = _sw.ElapsedMilliseconds;
                 var thisTime = endTime - startTime;
                 _analysisTime += thisTime;
-                if (thisTime >= 500 || (_analysisTime / _analysisCount) > 500) {                
+                if (thisTime >= 500 || (_analysisTime / _analysisCount) > 500) {
                     Trace.TraceWarning("Analyzed: {0} {1} ({2} count, {3}ms total, {4}ms mean)", this, thisTime, _analysisCount, _analysisTime, (double)_analysisTime / _analysisCount);
                 }
             }
 #endif
         }
 
         internal virtual void AnalyzeWorker(DDG ddg, CancellationToken cancel) {
-            if (Tree != ProjectEntry.Tree) {
-                // we were enqueued and a new version became available, don't re-analyze against
-                // the old version.
+            Debug.Assert(Ast != null, "Ast has unexpected null value");
+            Debug.Assert(ProjectEntry != null, "ProjectEntry has unexpected null value");
+
+            if (Ast == null || ProjectEntry == null || Tree != ProjectEntry.Tree) {
+                // analysis unit properties are invalid or we were enqueued and a new version became available
+                // don't re-analyze against the old version.
                 return;
             }
 

Nodejs/Product/Analysis/Analysis/VariableDef.cs

@@ -180,7 +180,7 @@ protected virtual void ExceedsTypeLimit() {
                     if (type.Value == null) {
                         continue;
                     }
-                    if (analyzer == null && type.Value.DeclaringModule != null) {
+                    if (analyzer == null && type.Value != null && type.Value.DeclaringModule != null) {
                         analyzer = type.Value.DeclaringModule.Analysis.ProjectState;
                     }
                     var str = type.ToString();