From 3c2869bbfd2ea8b369bab1d9fa978741652caa33 Mon Sep 17 00:00:00 2001 From: Copilot <223556219+Copilot@users.noreply.github.com> Date: Fri, 24 Jul 2026 07:27:33 +0000 Subject: [PATCH] test: fixme Accept-Language override test on WebKit Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `should send user Accept-Language header` is red on webkit-windows-latest only. WebKit on Windows appends the default language to a page-set `Accept-Language` header (got "de, en-US", expected "de"), so the fix in #41904 that stopped overriding page-set headers on macOS/Linux does not cover Windows. Scope a `fixme` to `webkit && isWindows`; the test still runs everywhere else. DB evidence (rolling window): webkit-windows-latest 45/46 runs failed (~98%), every other webkit bot (macOS, Ubuntu, xlarge, tracing) 0 failures; ongoing through 2026-07-24. Related issue: https://github.com/microsoft/playwright/issues/23732 Linked run history (webkit-windows-latest, oldest first): [🟥](https://github.com/microsoft/playwright/actions/runs/29856729151/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29859883032/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29865460136/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29866867131/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29867308985/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29873996100/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874748609/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874783963/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29877078341/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29879172510/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29904950059/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29915407358/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29918102409/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29924682554/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29931173316/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29932910968/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29933325202/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29938598979/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29940740538/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29945241493/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29957712363/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29960743816/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29986800439/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30000526442/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30002550609/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30003704436/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30012947805/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30013000317/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30013096187/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30016032633/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30019936660/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30020951577/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30028622968/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30030075729/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30034117131/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30037717793/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30043643329/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30046492986/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30046789125/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30047266180/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30054321343/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30055514373/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30056208622/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30059081941/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30061239008/attempts/1)[🟩](https://github.com/microsoft/playwright/actions/runs/30064063966/attempts/1) Verified locally on windows-latest: `npm run wtest browsercontext-locale.spec.ts:192` reproduced the failure ("de, en-US"), then confirmed the test is skipped on webkit-windows and still runs+passes on chromium (`npm run ctest`). Fix-flakes run: https://github.com/microsoft/playwright/actions/runs/30074510511 Suggested-reviewer: yury-s --- tests/library/browsercontext-locale.spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/library/browsercontext-locale.spec.ts b/tests/library/browsercontext-locale.spec.ts index 28c17871e97cf..8b1e94e56359c 100644 --- a/tests/library/browsercontext-locale.spec.ts +++ b/tests/library/browsercontext-locale.spec.ts @@ -191,7 +191,9 @@ it('should affect Intl.DateTimeFormat().resolvedOptions().locale', async ({ brow it('should send user Accept-Language header', { annotation: [{ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23732' }], -}, async ({ browser, server }) => { +}, async ({ browser, server, browserName, isWindows }) => { + it.fixme(browserName === 'webkit' && isWindows, 'WebKit on Windows appends the default language to the page-set Accept-Language header, https://github.com/microsoft/playwright/issues/23732'); + const context = await browser.newContext({ locale: 'en-GB' }); const page = await context.newPage(); await page.goto(server.EMPTY_PAGE);