Commit de090a9
Nitin Chaudhary
Fix: Allow localhost in inspector URL validation for Metro packager
The InspectorPackagerConnection validates URLs to the Metro packager's
inspector endpoint (ws://localhost:8081/inspector/device?...). This is
legitimate development infrastructure that only runs in dev mode.
Changes:
- Pass allowLocalhost=true to URL validator for inspector connections
- Remove throw statement - log validation failures but don't block
- Inspector is dev-only, connection will fail gracefully if invalid
This fixes E2E test failures where RNTesterApp couldn't launch because
the inspector connection was being blocked by SDL validation.
Root cause: Commit a74dae8 made inspector throw on validation failure,
but inspector URLs always point to localhost Metro packager in dev mode.1 parent cf53cbe commit de090a9
1 file changed
Lines changed: 5 additions & 2 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| 149 | + | |
| 150 | + | |
149 | 151 | | |
150 | | - | |
| 152 | + | |
151 | 153 | | |
152 | 154 | | |
153 | 155 | | |
154 | | - | |
| 156 | + | |
| 157 | + | |
155 | 158 | | |
156 | 159 | | |
157 | 160 | | |
| |||
0 commit comments