TypeScript 7.0 Can't compile `webpack`

[avivkeller]

Stack trace

panic: Debug failure. node needs to be an inferrable node
        Node KindJSTypeAliasDeclaration was unexpected. [recovered, repanicked]

goroutine 8978 [running]:
sync.(*WaitGroup).Go.func1.1()
        sync/waitgroup.go:251 +0x45
panic({0x7ff6f6968d00?, 0x3e2cb1ab7520?})
        runtime/panic.go:860 +0x13a
github.com/microsoft/typescript-go/internal/debug.Fail(...)
        github.com/microsoft/typescript-go/internal/debug/debug.go:14
github.com/microsoft/typescript-go/internal/debug.FailBadSyntaxKind({0x7ff6f6d91380?, 0x3e2c83e6e810?}, {0x3e2c928b0f20?, 0x3e2c928b0f30?, 0x1ce4?})
        github.com/microsoft/typescript-go/internal/debug/debug.go:24 +0xf4
github.com/microsoft/typescript-go/internal/pseudochecker.(*PseudoChecker).GetTypeOfDeclaration(0x7ff6f64ccb71?, 0x3e2c928b0fa0?)
        github.com/microsoft/typescript-go/internal/pseudochecker/lookup.go:64 +0x18a
github.com/microsoft/typescript-go/internal/checker.(*NodeBuilderImpl).serializeTypeForDeclaration(0x3e2cb0619280, 0x3e2c83e47188?, 0x800081c0d?, 0x7ff6f6da05b8?, 0x1)
        github.com/microsoft/typescript-go/internal/checker/nodebuilderimpl.go:2220 +0xade
github.com/microsoft/typescript-go/internal/checker.(*NodeBuilder).SerializeTypeForDeclaration(0x3e2ca1b227c0, 0x3e2c835bf4e8, 0x3e2c8eac7668, 0x18?, 0x35?, 0x0?, {0x7ff6f6da05b8?, 0x3e2c88a96c00?})
        github.com/microsoft/typescript-go/internal/checker/nodebuilder.go:136 +0x59
github.com/microsoft/typescript-go/internal/checker.(*EmitResolver).CreateTypeOfDeclaration(0x3e2c913a8ea0, 0x3e2c8bcafa40, 0x3e2c835bf4e8, 0x3e2c83e47188, 0x81c0d, 0x8, {0x7ff6f6da05b8, 0x3e2c88a96c00})
        github.com/microsoft/typescript-go/internal/checker/emitresolver.go:977 +0x174
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).ensureType(0x3e2c91ffc900, 0x3e2c835bf4e8, 0x0?)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1645 +0x36a
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).transformCommonJSExportWorker(0x3e2c91ffc900, 0x3e2c835bf4e8, 0x3e2c835cd6e8)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1469 +0xabb
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).transformCommonJSExport(0x3e2c91ffc900, 0x3e2c835bf4e8?, 0x7ff6f604ecd4?)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1296 +0x18
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visitNestedExpression(0x3e2c91ffc900, 0x3e2c835bf4e8)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:2668 +0xda
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitNode(0x3e2c928b1508?, 0x7ff6f658cb7d?)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:51 +0x27
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).visitNode(0x0?, 0x0?)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:198 +0x30
github.com/microsoft/typescript-go/internal/ast.(*ExpressionStatement).VisitEachChild(0x3e2c83e61988, 0x3e2c88a96de0)
        github.com/microsoft/typescript-go/internal/ast/ast_generated.go:1591 +0x27
github.com/microsoft/typescript-go/internal/ast.(*Node).VisitEachChild(...)
        github.com/microsoft/typescript-go/internal/ast/ast.go:208
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitEachChild(...)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:191
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visitNestedExpression(0x3e2c91ffc900, 0x3e2c83e61988)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:2681 +0x34a
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitSlice(0x3e2c88a96de0, {0x3e2c83e72830, 0x11, 0x11})
        github.com/microsoft/typescript-go/internal/ast/visitor.go:148 +0xc2
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitNodes(0x3e2c88a96de0, 0x3e2c83e51688)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:99 +0x37
github.com/microsoft/typescript-go/internal/printer.(*EmitContext).VisitVariableEnvironment(0x3e2c8bcafa40, 0x3e2c83e51688, 0x3e2c88a96de0)
        github.com/microsoft/typescript-go/internal/printer/emitcontext.go:761 +0x16d
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).visitTopLevelStatements(0x7ff6f625fed0?, 0x7ff6f6a7ed60?)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:255 +0x25
github.com/microsoft/typescript-go/internal/ast.(*SourceFile).VisitEachChild(0x3e2c83e47188, 0x3e2c88a96de0)
        github.com/microsoft/typescript-go/internal/ast/ast.go:2652 +0x2a
github.com/microsoft/typescript-go/internal/ast.(*Node).VisitEachChild(...)
        github.com/microsoft/typescript-go/internal/ast/ast.go:208
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitEachChild(...)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:191
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visitNestedExpression(0x3e2c91ffc900, 0x3e2c83e47188)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:2681 +0x34a
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitNode(0x3e2c928b1898?, 0x7ff6f6095e1d?)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:51 +0x27
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).transformSourceFile(0x3e2c91ffc900, 0x3e2c83e47188)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:349 +0xf7
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visitSourceFile(0x3e2c91ffc900, 0x3e2c83e47188)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:303 +0x2c5
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visit(0x3e2c86dae1e0?, 0x56?)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:231 +0xaf
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitNode(0x3e2c82c6dc00?, 0x3e2c8bcafa40?)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:51 +0x27
github.com/microsoft/typescript-go/internal/ast.(*NodeVisitor).VisitSourceFile(...)
        github.com/microsoft/typescript-go/internal/ast/visitor.go:36
github.com/microsoft/typescript-go/internal/transformers.(*Transformer).TransformSourceFile(...)
        github.com/microsoft/typescript-go/internal/transformers/transformer.go:40
github.com/microsoft/typescript-go/internal/compiler.(*emitter).runDeclarationTransformers(0x7ff6f604ecd4?, 0x3e2c85151b48?, 0x3e2c83e47188, {0x3e2c86dae1e0?, 0x1d71b314360?}, {0x0?, 0x3e2c80820808?})
        github.com/microsoft/typescript-go/internal/compiler/emitter.go:75 +0x27c
github.com/microsoft/typescript-go/internal/compiler.(*emitter).emitDeclarationFile(0x3e2c82c6dc00, 0x3e2c83e47188, {0x3e2c86dae1e0, 0x56}, {0x0, 0x0})
        github.com/microsoft/typescript-go/internal/compiler/emitter.go:225 +0x1f8
github.com/microsoft/typescript-go/internal/compiler.(*emitter).emit(0x3e2c82c6dc00)
        github.com/microsoft/typescript-go/internal/compiler/emitter.go:50 +0x13b
github.com/microsoft/typescript-go/internal/compiler.(*Program).Emit.func2()
        github.com/microsoft/typescript-go/internal/compiler/program.go:1680 +0x1b8
github.com/microsoft/typescript-go/internal/core.(*parallelWorkGroup).Queue.func1()
        github.com/microsoft/typescript-go/internal/core/workgroup.go:40 +0x13
sync.(*WaitGroup).Go.func1()
        sync/waitgroup.go:258 +0x4a
created by sync.(*WaitGroup).Go in goroutine 1
        sync/waitgroup.go:238 +0x73

Steps to reproduce

As a maintainer myself, I'm so so so sorry for the vague reproduction, but I can't seem to get this to repro on a smaller scale.

1. Clone webpack/webpack
2. Update typescript to ^7.0.0
3. Run npm run lint:types

[RyanCavanaugh]

I'm not seeing this. Any ideas?

> webpack@5.108.4 lint:types
> tsc

lib/serialization/PlainObjectSerializer.js:12:53 - error TS1003: Identifier expected.

12  * @typedef {WeakMap<CacheAssoc, ObjectStructure<T>>}
                                                       ~

lib/util/cleverMerge.js:103:23 - error TS1003: Identifier expected.

103 /** @typedef {(function(...EXPECTED_ANY): object) & { [DYNAMIC_INFO]: [DynamicFunction, object] }} DynamicFunction */
                          ~


Found 2 errors in 2 files.

Errors  Files
     1  lib/serialization/PlainObjectSerializer.js:12
     1  lib/util/cleverMerge.js:103

> npx tsc -v
Version 7.0.2

[avivkeller]

Hi! Sorry! It looks like I had declaration: true locally which was a requirement of the error, it seems. I'm still looking for a minimal repro.

[RyanCavanaugh]

No worries! Repro confirmed locally, I can reduce from here.

[weswigham]

From the just the stack frame, I'm guessing a @typedef merged with a module.exports.Something = whatever.

[RyanCavanaugh]

repro.js

'use strict';
/** @typedef {import('./local-lib/ModuleGraphConnection')} ImportedType */
/** @type {ImportedType} */
module.exports = class Repro {};

local-lib/ModuleGraphConnection.js

/** @typedef {typeof T} T */
const T = Symbol();
module.exports = class ModuleGraphConnection {};
module.exports.T = T;

tsc --allowJs --emitDeclarationOnly --ignoreConfig --declaration repro.js

panic: Debug failure. node needs to be an inferrable node
        Node KindJSTypeAliasDeclaration was unexpected. [recovered, repanicked]

goroutine 401 [running]:
sync.(*WaitGroup).Go.func1.1()
        sync/waitgroup.go:251 +0x45
panic({0x7ff789628d00?, 0xff30577e910?})
        runtime/panic.go:860 +0x13a
github.com/microsoft/typescript-go/internal/debug.Fail(...)
        github.com/microsoft/typescript-go/internal/debug/debug.go:14
github.com/microsoft/typescript-go/internal/debug.FailBadSyntaxKind({0x7ff789a51380?, 0xff30382e008?}, {0xff306750f20?, 0xff306750f30?, 0x168?})
        github.com/microsoft/typescript-go/internal/debug/debug.go:24 +0xf4
github.com/microsoft/typescript-go/internal/pseudochecker.(*PseudoChecker).GetTypeOfDeclaration(0x7ff78918cc47?, 0x7ff78a3a4020?)
        github.com/microsoft/typescript-go/internal/pseudochecker/lookup.go:64 +0x18a
github.com/microsoft/typescript-go/internal/checker.(*NodeBuilderImpl).serializeTypeForDeclaration(0xff3066fa080, 0xff303836008?, 0x800081c0d?, 0x7ff789a605b8?, 0x1)
        github.com/microsoft/typescript-go/internal/checker/nodebuilderimpl.go:2220 +0xade
github.com/microsoft/typescript-go/internal/checker.(*NodeBuilder).SerializeTypeForDeclaration(0xff3066ee100, 0xff302ca0618, 0xff303b36420, 0x18?, 0x89700160?, 0x7ff7?, {0x7ff789a605b8?, 0xff3066f4000?})
        github.com/microsoft/typescript-go/internal/checker/nodebuilder.go:136 +0x59
github.com/microsoft/typescript-go/internal/checker.(*EmitResolver).CreateTypeOfDeclaration(0xff30669c000, 0xff3066f2000, 0xff302ca0618, 0xff303836008, 0x81c0d, 0x8, {0x7ff789a605b8, 0xff3066f4000})
        github.com/microsoft/typescript-go/internal/checker/emitresolver.go:977 +0x174
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).ensureType(0xff3066f6000, 0xff302ca0618, 0x0?)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1645 +0x36a
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).transformCommonJSExportWorker(0xff3066f6000, 0xff302ca0618, 0xff3038301b8)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1469 +0xabb
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).transformCommonJSExport(0xff3066f6000, 0xff302ca0618?, 0x7ff788d0ecd4?)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:1296 +0x18
github.com/microsoft/typescript-go/internal/transformers/declarations.(*DeclarationTransformer).visitNestedExpression(0xff3066f6000, 0xff302ca0618)
        github.com/microsoft/typescript-go/internal/transformers/declarations/transform.go:2668 +0xda