[BUG] C# dev kit should respect the `dotnet.dotnetPath` set by C# extension

[ShreyasJejurkar]

Describe the Issue

If I set a custom path for dotnet SDK and runtime for C# extension using setting dotnet.dotnetPath like below.

    "dotnet.dotnetPath": "C:\\Users\\{username}\\AppData\\Local\\Microsoft\\dotnet"

I can see the C# extension uses that to load the base language service.

but if I see C# dev kit (and it's test explorer) logs, it's still loading it's tooling from the SDK found on the path.

which I think is incorrect, C# dev kit should respect the SDK chosen by base C# extension.

[AbhitejJohn]

@peterwald : Did we already address this?

[peterwald]

C# Dev Kit's Test Explorer does not use the dotnet.dotnetPath currently. We should probably update it to use the same setting here as the C# extension.

[ShreyasJejurkar]

1 thing of 100 things.

C# Dev kit components should not deviate from the options set by base C# extension.
This single thing will avoid plethora of bugs and issues.

[kepiz]

Any way to fix this in the meantime?

[peterwald]

The extension has been updated to set the DOTNET_ROOT for child processes to the value of dotnet.dotnetPath when set. The change will ship in the next prerelease version.

[ShreyasJejurkar]

Is this even made to pre-release or not yet? I have the below version installed.

When I check logs, I still see the C# dev kit loading the runtime from the path variable instead of the configured one in VSCode JSON settings.

[peterwald]

@ShreyasJejurkar Yes, that change should be in pre-release.

Note that the log message you are seeing there is a different code path than what I updated. I believe that log message is showing which instance of .NET is being used to run the language services.

After my change, child processes of the extension (i.e. your tests) should run with DOTNET_ROOT set in the environment to the value of dotnet.dotnetPath.

Can you describe what you are trying to accomplish here?

[ShreyasJejurkar]

I believe that log message is showing which instance of .NET is being used to run the language services

I don't think that is true, because when I see the base C# extension logs, I can see it's using the dotnetPath set by me in settings.json which is correct.

But whereas if you see the C# dev kit and its component, they are still loading their stuff from the dotnet found on the path, instead of using the ones that the user has configured using dotnet:dotnetPath.

So the issue, the C# dev kit and its component should not load their components from another dotnet sdk if the user has configured the dotnetpath in settings.

[peterwald]

@lifengl @arkalyanms @timheuer Do you have any thoughts on this? This is not a testing issue, it's more core to the dev environment.