bugfix: Stop calling 'java.getPackageData' when the dependency explorer is not visible (#259)

Author: jdneo

src/views/dependencyExplorer.ts

@@ -1,47 +1,53 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
-import { ExtensionContext, TextEditor, TreeView, TreeViewVisibilityChangeEvent, Uri, window } from "vscode";
+import { Disposable, ExtensionContext, TextEditor, TreeView, TreeViewVisibilityChangeEvent, Uri, window } from "vscode";
 import { Jdtls } from "../java/jdtls";
 import { INodeData } from "../java/nodeData";
 import { Settings } from "../settings";
 import { DataNode } from "./dataNode";
 import { DependencyDataProvider } from "./dependencyDataProvider";
 import { ExplorerNode } from "./explorerNode";
 
-export class DependencyExplorer {
+export class DependencyExplorer implements Disposable {
 
     private _dependencyViewer: TreeView<ExplorerNode>;
 
     private _dataProvider: DependencyDataProvider;
 
-    private _selectionWhenHidden: DataNode;
-
     constructor(public readonly context: ExtensionContext) {
         this._dataProvider = new DependencyDataProvider(context);
         this._dependencyViewer = window.createTreeView("javaDependencyExplorer", { treeDataProvider: this._dataProvider, showCollapseAll: true });
 
-        window.onDidChangeActiveTextEditor((textEditor: TextEditor) => {
-            if (textEditor && textEditor.document && Settings.syncWithFolderExplorer()) {
-                this.reveal(textEditor.document.uri);
-            }
-        });
-
-        this._dependencyViewer.onDidChangeVisibility((e: TreeViewVisibilityChangeEvent) => {
-            if (e.visible && this._selectionWhenHidden) {
-                this._dependencyViewer.reveal(this._selectionWhenHidden);
-                this._selectionWhenHidden = undefined;
-            }
-        });
-
-        this._dataProvider.onDidChangeTreeData(() => {
-            if (window.activeTextEditor && Settings.syncWithFolderExplorer()) {
-                this.reveal(window.activeTextEditor.document.uri);
-            }
-        });
+        context.subscriptions.push(
+            window.onDidChangeActiveTextEditor((textEditor: TextEditor) => {
+                if (this._dependencyViewer.visible && textEditor && textEditor.document && Settings.syncWithFolderExplorer()) {
+                    this.reveal(textEditor.document.uri);
+                }
+            }),
+        );
+
+        context.subscriptions.push(
+            this._dependencyViewer.onDidChangeVisibility((e: TreeViewVisibilityChangeEvent) => {
+                if (e.visible && window.activeTextEditor && Settings.syncWithFolderExplorer()) {
+                    this.reveal(window.activeTextEditor.document.uri);
+                }
+            }),
+        );
+
+        context.subscriptions.push(
+            this._dataProvider.onDidChangeTreeData(() => {
+                if (window.activeTextEditor && Settings.syncWithFolderExplorer()) {
+                    this.reveal(window.activeTextEditor.document.uri);
+                }
+            }),
+        );
     }
 
     public dispose(): void {
+        if (this._dependencyViewer) {
+            this._dependencyViewer.dispose();
+        }
     }
 
     public async reveal(uri: Uri): Promise<void> {
@@ -53,8 +59,6 @@ export class DependencyExplorer {
 
         if (this._dependencyViewer.visible) {
             this._dependencyViewer.reveal(node);
-        } else {
-            this._selectionWhenHidden = node;
         }
     }
 }