nit + delete fairly useless test

Author: alexr00

src/github/githubRepository.ts

@@ -1343,12 +1343,12 @@ export class GitHubRepository extends Disposable {
 		return data.repository?.ref?.target.oid;
 	}
 
-	private static branchesCacheKey(owner: string, repositoryName: string): string {
+	private branchesCacheKey(owner: string, repositoryName: string): string {
 		return `${owner}/${repositoryName}`;
 	}
 
 	getCachedBranches(owner: string, repositoryName: string): string[] | undefined {
-		return this._branchesCache.get(GitHubRepository.branchesCacheKey(owner, repositoryName));
+		return this._branchesCache.get(this.branchesCacheKey(owner, repositoryName));
 	}
 
 	async listBranches(owner: string, repositoryName: string, prefix: string | undefined): Promise<string[]> {
@@ -1394,7 +1394,7 @@ export class GitHubRepository extends Disposable {
 		}
 		// Cache results for unprefixed queries
 		if (!prefix) {
-			this._branchesCache.set(GitHubRepository.branchesCacheKey(owner, repositoryName), branches);
+			this._branchesCache.set(this.branchesCacheKey(owner, repositoryName), branches);
 		}
 		return branches;
 	}

src/test/github/githubRepository.test.ts

@@ -52,24 +52,4 @@ describe('GitHubRepository', function () {
 			// assert(! dotcomRepository.isGitHubDotCom);
 		});
 	});
-
-	describe('getCachedBranches', function () {
-		it('returns undefined when no branches have been cached', function () {
-			const url = 'https://github.com/owner/repo';
-			const remote = new GitHubRemote('origin', url, new Protocol(url), GitHubServerType.GitHubDotCom);
-			const rootUri = Uri.file('C:\\users\\test\\repo');
-			const repo = new GitHubRepository(1, remote, rootUri, credentialStore, telemetry);
-
-			assert.strictEqual(repo.getCachedBranches('owner', 'repo'), undefined);
-		});
-
-		it('returns undefined for an owner/repo with no cache entry', function () {
-			const url = 'https://github.com/owner/repo';
-			const remote = new GitHubRemote('origin', url, new Protocol(url), GitHubServerType.GitHubDotCom);
-			const rootUri = Uri.file('C:\\users\\test\\repo');
-			const repo = new GitHubRepository(1, remote, rootUri, credentialStore, telemetry);
-
-			assert.strictEqual(repo.getCachedBranches('other-owner', 'other-repo'), undefined);
-		});
-	});
 });