Skip to content

Commit 3166f58

Browse files
authored
Merge branch 'master' into improve-cdp-message
2 parents 38332d3 + 75d79c8 commit 3166f58

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

test/smoke/suites/activation.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ export function startExtensionActivationTests(): void {
4242
try {
4343
await ElementHelper.WaitElementSelectorVisible(
4444
`[id="${Constant.previewExtensionId}"]`,
45-
2000,
45+
10000,
4646
);
4747
SmokeTestLogger.info("React-native preview extension is activated");
4848
isActivited = true;
4949
} catch {
5050
try {
5151
await ElementHelper.WaitElementSelectorVisible(
5252
`[id="${Constant.prodExtensionId}"]`,
53-
2000,
53+
10000,
5454
);
5555
SmokeTestLogger.info("React-native prod extension is activated");
5656
isActivited = true;

test/smoke/suites/helper/application.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class Application {
5454
timeout: 10000,
5555
});
5656

57-
await utilities.sleep(5000);
57+
await utilities.sleep(10000);
5858
return this.mainPage;
5959
}
6060

@@ -74,7 +74,13 @@ export class Application {
7474

7575
async installExtensionFromVSIX(vscodeExecutablePath: string): Promise<void> {
7676
const [cliPath, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
77-
args.push(`--extensions-dir=${this.extensionDirectory}`);
77+
// Remove existing --extensions-dir if present to avoid duplication
78+
const extensionsDirIndex = args.findIndex(arg => arg.startsWith("--extensions-dir="));
79+
if (extensionsDirIndex >= 0) {
80+
args[extensionsDirIndex] = `--extensions-dir=${this.extensionDirectory}`;
81+
} else {
82+
args.push(`--extensions-dir=${this.extensionDirectory}`);
83+
}
7884
let extensionFile = utilities.findFile(this.vsixDirectory, /.*\.(vsix)/);
7985
if (!extensionFile) {
8086
throw new Error(`React Native extension .vsix is not found in ${this.vsixDirectory}`);

0 commit comments

Comments
 (0)