Clean up unused options in quick debugging action list (#2415)

EzioLi01 · web-flow · commit 5b0c8906f37a · 2025-09-11T16:33:37.000+08:00
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -6,19 +6,27 @@
             "type": "extensionHost",
             "request": "launch",
             "runtimeExecutable": "${execPath}",
-            "args": ["--extensionDevelopmentPath=${workspaceRoot}"],
+            "args": [
+                "--extensionDevelopmentPath=${workspaceRoot}"
+            ],
             "sourceMaps": true,
-            "outFiles": ["${workspaceRoot}/src/**/*.js"],
+            "outFiles": [
+                "${workspaceRoot}/src/**/*.js"
+            ],
             "preLaunchTask": "gulp: build"
         },
         {
             "name": "Quick Launch Extension",
             "type": "extensionHost",
             "request": "launch",
             "runtimeExecutable": "${execPath}",
-            "args": ["--extensionDevelopmentPath=${workspaceRoot}"],
+            "args": [
+                "--extensionDevelopmentPath=${workspaceRoot}"
+            ],
             "sourceMaps": true,
-            "outFiles": ["${workspaceRoot}/src/**/*.js"]
+            "outFiles": [
+                "${workspaceRoot}/src/**/*.js"
+            ]
         },
         {
             "name": "Launch Extension tests",
@@ -31,7 +39,9 @@
                 "--extensionTestsPath=${workspaceRoot}/test"
             ],
             "sourceMaps": true,
-            "outFiles": ["${workspaceRoot}/src/**/*.js"],
+            "outFiles": [
+                "${workspaceRoot}/src/**/*.js"
+            ],
             "preLaunchTask": "gulp: build"
         },
         {
@@ -45,21 +55,29 @@
                 "--extensionTestsPath=${workspaceRoot}/test/localization"
             ],
             "sourceMaps": true,
-            "outFiles": ["${workspaceRoot}/src/**/*.js"],
+            "outFiles": [
+                "${workspaceRoot}/src/**/*.js"
+            ],
             "preLaunchTask": "gulp: build"
         },
         {
-            "name": "Launch All Smoke Tests",
+            "name": "Launch Smoke Tests",
             "type": "node",
             "request": "launch",
             "program": "${workspaceFolder}/test/smoke/node_modules/mocha/bin/_mocha",
             "cwd": "${workspaceFolder}/test/smoke",
-            "args": ["--dont-delete-vsix"],
+            "args": [
+                "--config ./.mocharc.js ",
+                "--reporter mocha-multi-reporters"
+            ],
             "timeout": 240000,
             "stopOnEntry": false,
-            "outFiles": ["${workspaceRoot}/src/**/*.js"],
-            "sourceMaps": true
+            "outFiles": [
+                "${workspaceFolder}/test/smoke/out/**/*.js"
+            ],
+            "sourceMaps": true,
+            "preLaunchTask": "npm: compile-smoke-tests"
         }
     ],
     "compounds": []
-}
+}
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -1,67 +1,20 @@
 {
     "version": "2.0.0",
     "tasks": [
-        {
-            "label": "prepare-smoke-tests",
-            "type": "process",
-            "command": [
-                "yarn"
-            ],
-            "windows": {
-                "command": "yarn.cmd"
-            },
-            "args": [
-                "prepare-smoke-tests"
-            ],
-            "presentation": {
-                "echo": true,
-                "reveal": "silent",
-                "focus": false,
-                "panel": "shared",
-                "showReuseMessage": false,
-                "clear": false
-            }
-        },
-        {
-            "label": "compile-smoke-tests",
-            "type": "process",
-            "command": [
-                "./node_modules/.bin/tsc"
-            ],
-            "windows": {
-                "command": ".\\node_modules\\.bin\\tsc.cmd"
-            },
-            "options": {
-                "cwd": "${workspaceRoot}/test/smoke/vscode/test/smoke"
-            },
-            "presentation": {
-                "echo": true,
-                "reveal": "silent",
-                "focus": false,
-                "panel": "shared",
-                "showReuseMessage": false,
-                "clear": false
-            }
-        },
-        {
-            "label": "Prepare Smoke Tests",
-            "dependsOn": [
-                "prepare-smoke-tests"
-            ]
-        },
-        {
-            "label": "Build Smoke Tests",
-            "dependsOn": [
-                "compile-smoke-tests"
-            ]
-        },
         {
             "type": "npm",
             "script": "build",
             "group": "build",
             "problemMatcher": [],
             "label": "gulp: build",
             "detail": "gulp build"
+        },
+        {
+            "label": "npm: compile-smoke-tests",
+            "type": "shell",
+            "command": "npm run compile-smoke-tests",
+            "group": "build",
+            "problemMatcher": []
         }
     ]
-}
+}
diff --git a/package.json b/package.json
@@ -485,34 +485,6 @@
           "command": "reactNative.debugScenario.attachHermesApplication",
           "when": "isRNProject && isRNHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
-        {
-          "command": "reactNative.debugScenario.attachDirectIosExperimental",
-          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.attachToPackager",
-          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugAndroid",
-          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugIos",
-          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugWindows",
-          "when": "isRNProject && isRNWindowsProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugMacos",
-          "when": "isRNProject && isRNMacOSProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugInExponent",
-          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
         {
           "command": "reactNative.debugScenario.debugInHermesExponent",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
@@ -523,42 +495,26 @@
         },
         {
           "command": "reactNative.debugScenario.debugAndroidHermes",
-          "when": "isRNProject && isRNAndroidHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugDirectIosExperimental",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
         {
           "command": "reactNative.debugScenario.debugIosHermes",
-          "when": "isRNProject && isRNIosHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
+          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
         {
           "command": "reactNative.debugScenario.debugMacosHermes",
-          "when": "isRNProject && isRNMacosHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.debugWindowsHermes",
-          "when": "isRNProject && isRNWindowsHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.runAndroid",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
         {
-          "command": "reactNative.debugScenario.runIos",
+          "command": "reactNative.debugScenario.debugWindowsHermes",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
         {
           "command": "reactNative.debugScenario.runAndroidHermes",
-          "when": "isRNProject && isRNAndroidHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
+          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
         {
           "command": "reactNative.debugScenario.runIosHermes",
-          "when": "isRNProject && isRNIosHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
-        },
-        {
-          "command": "reactNative.debugScenario.runDirectIosExperimental",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         }
       ],
@@ -1419,6 +1375,7 @@
     "prepare": "husky install",
     "prepare-smoke-tests": "cd test/smoke && npm ci",
     "prepare-smoke-tests-project": "cd test/smoke/resources/sampleReactNativeProject && npm install",
+    "compile-smoke-tests": "cd test/smoke && tsc",
     "smoke-tests": "cd test/smoke && tsc && node ./node_modules/mocha/bin/_mocha --config ./.mocharc.js --reporter mocha-multi-reporters"
   },
   "prettier": {
diff --git a/test/smoke/suites/actionBar.test.ts b/test/smoke/suites/actionBar.test.ts
@@ -0,0 +1,65 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for details.
+
+import { Page } from "playwright";
+import { SmokeTestLogger } from "./helper/smokeTestLogger";
+import { app, screenshots } from "./main";
+import { ElementHelper } from "./helper/elementHelper";
+import { Element } from "./helper/constants";
+import { WaitHelper } from "./helper/waitHelper";
+import { ComponentHelper } from "./helper/componentHelper";
+import * as assert from "assert";
+
+export function startActionBarTests(): void {
+    describe("ActionBarTest", () => {
+        async function initApp(): Promise<Page> {
+            await app.launch();
+            return app.getMainPage();
+        }
+
+        async function dispose() {
+            if (this.currentTest?.state === "failed") {
+                SmokeTestLogger.info("Test failed, taking screenshot ...");
+                await screenshots.takeScreenshots(
+                    this.currentTest.parent?.title || "Others",
+                    this.currentTest.title.replace(/\s+/g, "_"),
+                );
+            }
+            try {
+                SmokeTestLogger.info(`Dispose test: "${this.currentTest.title}" ...`);
+                if (app) {
+                    await app.close();
+                }
+            } catch (error) {
+                SmokeTestLogger.error(`Error while dispose: ${error}`);
+            }
+        }
+
+        afterEach(dispose);
+
+        it("Verify extension quick debug action button is working correctly", async () => {
+            await initApp();
+
+            const debugActionItemDropdown = await ElementHelper.TryFindElement(
+                `[aria-label="${Element.debugActionItemDropdownAriaLable}"]`,
+            );
+            assert.notStrictEqual(debugActionItemDropdown, null);
+
+            const actionButton = await ElementHelper.WaitElementSelectorVisible(
+                Element.debugActionItemButtonSelector,
+            );
+            actionButton.click();
+
+            await WaitHelper.waitIsTrue(async () => {
+                const packager = await ComponentHelper.getReactNativePackager();
+                const currentState = await packager.getAttribute("aria-label");
+                try {
+                    assert.ok(currentState?.includes("primitive-square"));
+                    return true;
+                } catch {
+                    return false;
+                }
+            });
+        });
+    });
+}
diff --git a/test/smoke/suites/activation.test.ts b/test/smoke/suites/activation.test.ts
@@ -44,15 +44,15 @@ export function startExtensionActivationTests(): void {
                     `[id="${Constant.previewExtensionId}"]`,
                     2000,
                 );
-                SmokeTestLogger.info("React-native-preview extension is activated");
+                SmokeTestLogger.info("React-native preview extension is activated");
                 isActivited = true;
             } catch {
                 try {
                     await ElementHelper.WaitElementSelectorVisible(
                         `[id="${Constant.prodExtensionId}"]`,
                         2000,
                     );
-                    SmokeTestLogger.info("React-native-prod extension is activated");
+                    SmokeTestLogger.info("React-native prod extension is activated");
                     isActivited = true;
                 } catch {
                     isActivited = false;
diff --git a/test/smoke/suites/helper/componentHelper.ts b/test/smoke/suites/helper/componentHelper.ts
@@ -5,7 +5,7 @@ import { Constant, Element } from "./constants";
 import { SmokeTestLogger } from "./smokeTestLogger";
 
 export class ComponentHelper {
-    static setPage(): Page {
+    static Page(): Page {
         const application = app;
         return application.getMainPage();
     }
@@ -35,10 +35,7 @@ export class ComponentHelper {
         fileName: string,
     ): Promise<ElementHandle<SVGElement | HTMLElement> | null> {
         try {
-            return await ElementHelper.WaitElementSelectorVisible(
-                `[aria-label="${fileName}"]`,
-                2000,
-            );
+            return await ElementHelper.WaitElementAriaLabelVisible(fileName, 2000);
         } catch {
             return null;
         }
diff --git a/test/smoke/suites/helper/constants.ts b/test/smoke/suites/helper/constants.ts
@@ -9,4 +9,6 @@ export class Element {
     public static commandPaletteFocusedItemSelector = "#quickInput_list .monaco-list-row.focused";
     public static fileExplorerIconSelector = ".action-label.codicon.codicon-explorer-view-icon";
     public static fileExplorerViewId = "workbench.view.explorer";
+    public static debugActionItemDropdownAriaLable = "Run or Debug...";
+    public static debugActionItemButtonSelector = ".action-label.codicon.codicon-debug-alt";
 }
diff --git a/test/smoke/suites/helper/elementHelper.ts b/test/smoke/suites/helper/elementHelper.ts
diff --git a/test/smoke/suites/helper/waitHelper.ts b/test/smoke/suites/helper/waitHelper.ts
diff --git a/test/smoke/suites/smoke.test.ts b/test/smoke/suites/smoke.test.ts

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,6 @@ export class Element {`
`9`	`9`	`public static commandPaletteFocusedItemSelector = "#quickInput_list .monaco-list-row.focused";`
`10`	`10`	`public static fileExplorerIconSelector = ".action-label.codicon.codicon-explorer-view-icon";`
`11`	`11`	`public static fileExplorerViewId = "workbench.view.explorer";`
	`12`	`+ public static debugActionItemDropdownAriaLable = "Run or Debug...";`
	`13`	`+ public static debugActionItemButtonSelector = ".action-label.codicon.codicon-debug-alt";`
`12`	`14`	`}`