Add unit test for getting workspace settings (#2062)

* Add unit test for getting workspace settings

* Add unit test for getting workspace settings

* Update

* Update

Author: EzioLi01

src/extension/rn-extension.ts

@@ -284,7 +284,8 @@ export function getCountOfWorkspaceFolders(): number {
 }
 
 export async function onFolderAdded(folder: vscode.WorkspaceFolder): Promise<void> {
-    const excludeFolders = await SettingsHelper.getWorkspaceFileExcludeFolder();
+    const workspacePath = vscode.workspace.workspaceFile?.fsPath;
+    const excludeFolders = await SettingsHelper.getWorkspaceFileExcludeFolder(workspacePath);
     let isExclude = false;
     if (excludeFolders.length != 0) {
         for (let i = 0; i < excludeFolders.length; i++) {

src/extension/settingsHelper.ts

@@ -206,16 +206,20 @@ export class SettingsHelper {
         }
     }
 
-    public static async getWorkspaceFileExcludeFolder(): Promise<any> {
-        const workspacePath = vscode.workspace.workspaceFile?.fsPath;
-        const workspaceSettingsContent = workspacePath
-            ? JSON.parse(fs.readFileSync(workspacePath, "utf-8"))
+    public static async getWorkspaceFileExcludeFolder(
+        settingsPath: string | undefined,
+    ): Promise<any> {
+        const workspaceSettingsContent = settingsPath
+            ? JSON.parse(fs.readFileSync(settingsPath, "utf-8"))
             : null;
         if (workspaceSettingsContent) {
-            const exclude = workspaceSettingsContent.settings["react-native.workspace.exclude"];
-            return exclude ? exclude : [];
-        } else {
-            return [];
+            if (workspaceSettingsContent.settings) {
+                const exclude = workspaceSettingsContent.settings["react-native.workspace.exclude"];
+                return exclude ? exclude : [];
+            } else {
+                return [];
+            }
         }
+        return [];
     }
 }

test/extension/workspace.test.ts

@@ -0,0 +1,41 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for details.
+
+import * as assert from "assert";
+import * as path from "path";
+import { SettingsHelper } from "../../src/extension/settingsHelper";
+
+suite("workspace", function () {
+    suite("extensionContext", function () {
+        test("Should get react-native.workspace.exclude correctly from workspace settings file", async function () {
+            const noWorkspacePath = undefined;
+            const exclude1 = await SettingsHelper.getWorkspaceFileExcludeFolder(noWorkspacePath);
+            assert.strictEqual(exclude1.length, 0);
+
+            const noExcludeWorkspacePath = path.resolve(
+                __dirname,
+                "..",
+                "resources",
+                "workspaceSettingsSample",
+                "noExcludeSetting.json",
+            );
+            const exclude2 = await SettingsHelper.getWorkspaceFileExcludeFolder(
+                noExcludeWorkspacePath,
+            );
+            assert.strictEqual(exclude2.length, 0);
+
+            const excludeWorkspacePath = path.resolve(
+                __dirname,
+                "..",
+                "resources",
+                "workspaceSettingsSample",
+                "excludeSetting.json",
+            );
+            const exclude3 = await SettingsHelper.getWorkspaceFileExcludeFolder(
+                excludeWorkspacePath,
+            );
+            assert.strictEqual(exclude3.length, 1);
+            assert.strictEqual(exclude3[0], "testProject2");
+        });
+    });
+});

test/resources/workspaceSettingsSample/excludeSetting.json

@@ -0,0 +1,15 @@
+{
+	"folders": [
+		{
+			"path": "testProject1"
+		},
+        {
+			"path": "testProject2"
+		}
+	],
+	"settings": {
+		"react-native.workspace.exclude": [
+			"testProject2"
+		]
+	}
+}

test/resources/workspaceSettingsSample/noExcludeSetting.json

@@ -0,0 +1,7 @@
+{
+	"folders": [
+		{
+			"path": "testProject"
+		}
+	]
+}