Merge branch 'master' into extract-uplicate-code-as-a-common-base-class

Author: EmmaYuan1015

package-lock.json

@@ -25,7 +25,7 @@
     "playwright": "^1.55.1",
     "rimraf": "^6.0.1",
     "shell-quote": "^1.8.3",
-    "tar": "7.5.3",
+    "tar": "7.5.4",
     "tree-kill": "^1.2.2",
     "ts-node": "10.9.2",
     "typescript": "5.9.2",

test/smoke/package-lock.json

@@ -6,6 +6,7 @@ import { ElementHelper } from "./helper/elementHelper";
 import { Constant } from "./helper/constants";
 import { BaseSmokeTest } from "./helper/baseSmokeTest";
 import { SmokeTestLogger } from "./helper/smokeTestLogger";
+import { TimeoutConstants } from "./helper/timeoutConstants";
 
 export function startExtensionActivationTests(): void {
     describe("ExtensionActivationTest", () => {
@@ -18,15 +19,15 @@ export function startExtensionActivationTests(): void {
             try {
                 await ElementHelper.WaitElementSelectorVisible(
                     `[id="${Constant.previewExtensionId}"]`,
-                    10000,
+                    TimeoutConstants.ACTIVATION_TIMEOUT,
                 );
                 SmokeTestLogger.info("React-native preview extension is activated");
                 isActivited = true;
             } catch {
                 try {
                     await ElementHelper.WaitElementSelectorVisible(
                         `[id="${Constant.prodExtensionId}"]`,
-                        10000,
+                        TimeoutConstants.ACTIVATION_TIMEOUT,
                     );
                     SmokeTestLogger.info("React-native prod extension is activated");
                     isActivited = true;

test/smoke/package.json

@@ -7,6 +7,7 @@ import { ElementHelper } from "./helper/elementHelper";
 import { Element } from "./helper/constants";
 import { BaseSmokeTest } from "./helper/baseSmokeTest";
 import { SmokeTestLogger } from "./helper/smokeTestLogger";
+import { TimeoutConstants } from "./helper/timeoutConstants";
 
 export function startCDPNodeVersionCompatibilityTests(): void {
     describe("CDPNodeVersionCompatibilityTest", () => {
@@ -18,7 +19,7 @@ export function startCDPNodeVersionCompatibilityTests(): void {
             await ComponentHelper.openRunAndDebugTab();
             await ElementHelper.WaitElementClassNameVisible(
                 Element.runAndDebugTabButtonClassName,
-                5000,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
             );
 
             SmokeTestLogger.info("Run and Debug tab is accessible");
@@ -28,12 +29,15 @@ export function startCDPNodeVersionCompatibilityTests(): void {
             await BaseSmokeTest.initApp();
 
             await ComponentHelper.openCommandPalette();
-            await ElementHelper.WaitElementClassNameVisible(Element.commandPaletteClassName, 5000);
+            await ElementHelper.WaitElementClassNameVisible(
+                Element.commandPaletteClassName,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
+            );
 
             await ElementHelper.inputText("debug");
             const option = await ElementHelper.WaitElementSelectorVisible(
                 Element.commandPaletteFocusedItemSelector,
-                5000,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
             );
 
             const value = await option.getAttribute("aria-label");

test/smoke/suites/activation.test.ts

@@ -8,7 +8,7 @@ import * as assert from "assert";
 import { ElementHelper } from "./helper/elementHelper";
 import { Element } from "./helper/constants";
 import { ComponentHelper } from "./helper/componentHelper";
-
+import { TimeoutConstants } from "./helper/timeoutConstants";
 export function startCommandPaletteTests(): void {
     describe("CommandPaletteTest", () => {
         async function initApp(): Promise<Page> {
@@ -41,12 +41,15 @@ export function startCommandPaletteTests(): void {
             await initApp();
 
             await ComponentHelper.openCommandPalette();
-            await ElementHelper.WaitElementClassNameVisible(Element.commandPaletteClassName, 5000);
+            await ElementHelper.WaitElementClassNameVisible(
+                Element.commandPaletteClassName,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
+            );
 
             await ElementHelper.inputText(text);
             const option = await ElementHelper.WaitElementSelectorVisible(
                 Element.commandPaletteFocusedItemSelector,
-                5000,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
             );
 
             const value = await option.getAttribute("aria-label");

test/smoke/suites/cdpNodeVersionCompatibility.test.ts

@@ -10,6 +10,7 @@ import * as assert from "assert";
 import { ElementHelper } from "./helper/elementHelper";
 import { Element } from "./helper/constants";
 import { ComponentHelper } from "./helper/componentHelper";
+import { TimeoutConstants } from "./helper/timeoutConstants";
 
 export function startDebugConfigurationTests(): void {
     describe("DebugConfigurationTest", () => {
@@ -89,7 +90,7 @@ export function startDebugConfigurationTests(): void {
 
             const reactNativeButton = await ElementHelper.WaitElementSelectorVisible(
                 Element.reactNativeButtonSelector,
-                5000,
+                TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
             );
             await reactNativeButton.click();
 
@@ -120,7 +121,7 @@ export function startDebugConfigurationTests(): void {
             for (let attempt = 0; attempt < maxAttempts; attempt++) {
                 const configurationElement = await ElementHelper.TryFindElement(
                     Element.configurationElementSelector,
-                    5000,
+                    TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
                 );
                 launchContent = await configurationElement?.textContent();
                 if (launchContent) {

test/smoke/suites/commands.test.ts

@@ -9,6 +9,7 @@ import { SmokeTestLogger } from "./smokeTestLogger";
 import * as fs from "fs";
 import * as rimraf from "rimraf";
 import { Element } from "./constants";
+import { TimeoutConstants } from "./timeoutConstants";
 
 export class Application {
     private app: ElectronApplication | null = null;
@@ -55,7 +56,7 @@ export class Application {
             timeout: 30000,
         });
 
-        await utilities.sleep(10000);
+        await utilities.sleep(TimeoutConstants.APPLICATION_INIT_SLEEP);
         return this.mainPage;
     }
 

test/smoke/suites/debugConfiguration.test.ts

@@ -4,6 +4,7 @@ import { ElementHelper } from "./elementHelper";
 import { Constant, Element } from "./constants";
 import { WaitHelper } from "./waitHelper";
 import { SmokeTestLogger } from "./smokeTestLogger";
+import { TimeoutConstants } from "./timeoutConstants";
 
 export class ComponentHelper {
     static Page(): Page {
@@ -18,15 +19,18 @@ export class ComponentHelper {
 
     public static async executeCommand(commandName: string) {
         await this.openCommandPalette();
-        await ElementHelper.WaitElementClassNameVisible(Element.commandPaletteClassName, 5000);
+        await ElementHelper.WaitElementClassNameVisible(
+            Element.commandPaletteClassName,
+            TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
+        );
 
         // Type the command name to search for it
         await ElementHelper.inputText(commandName);
 
         // Wait for the command to appear in the list
         await ElementHelper.WaitElementSelectorVisible(
             Element.commandPaletteFocusedItemSelector,
-            5000,
+            TimeoutConstants.COMMAND_PALETTE_TIMEOUT,
         );
 
         // Press Enter to execute the command

test/smoke/suites/helper/application.ts

@@ -0,0 +1,29 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for details.
+
+/**
+ * Timeout constants for smoke tests
+ * Centralized configuration for all timeout values used across test suites
+ */
+export class TimeoutConstants {
+    /** Activation timeout - 10 seconds */
+    static readonly ACTIVATION_TIMEOUT = 10000;
+
+    /** Application initialization sleep - 10 seconds */
+    static readonly APPLICATION_INIT_SLEEP = 10000;
+
+    /** Command palette visibility timeout - 5 seconds */
+    static readonly COMMAND_PALETTE_TIMEOUT = 5000;
+
+    /** Package loader timeout - 4 minutes (240 seconds) */
+    static readonly PACKAGE_LOADER_TIMEOUT = 4 * 60 * 1000;
+
+    /** Command executor timeout - 10 seconds */
+    static readonly COMMAND_EXECUTOR_TIMEOUT = 10000;
+
+    /** Clean & Restart Packager timeout - 5 minutes (300 seconds) */
+    static readonly PACKAGER_CLEAN_RESTART_TIMEOUT = 300000;
+
+    /** Packager state change timeout - 3 minutes (180 seconds) */
+    static readonly PACKAGER_STATE_TIMEOUT = 180000;
+}