Description
The terminal sandbox settings were migrated to their current names some time ago, but deprecated setting IDs and compatibility paths remain registered and consumed across the workbench.
These legacy paths add unnecessary complexity and can allow stale deprecated values to influence effective sandbox configuration.
Proposed change
Remove the deprecated terminal sandbox settings and their remaining compatibility code:
- deprecated sandbox enabled and filesystem setting IDs
- deprecated sandbox network-domain setting IDs
- configuration registrations and migrations for those settings
- fallback reads and change listeners
- terminal exports and compatibility-only tests
- stale deprecated-setting handling and comments in
TerminalSandboxEngine and its host adapters
The engine should consume only canonical modern sandbox settings.
Validation
- TypeScript client transpilation succeeds
- no editor diagnostics
git diff --check passes
Pull request
Implemented by #327881.
Description
The terminal sandbox settings were migrated to their current names some time ago, but deprecated setting IDs and compatibility paths remain registered and consumed across the workbench.
These legacy paths add unnecessary complexity and can allow stale deprecated values to influence effective sandbox configuration.
Proposed change
Remove the deprecated terminal sandbox settings and their remaining compatibility code:
TerminalSandboxEngineand its host adaptersThe engine should consume only canonical modern sandbox settings.
Validation
git diff --checkpassesPull request
Implemented by #327881.