Fixing CheckStyle issues

Fixing a number of check style issues

Author: Peter Nied

graphsdk/src/main/java/com/microsoft/graph/model/DateOnly.java

@@ -9,22 +9,35 @@
  */
 public class DateOnly {
 
-    private final int
-            mYear,
-            mMonth,
-            mDay;
+    /**
+     * The year
+     */
+    private final int mYear;
+
+    /**
+     * The month
+     */
+    private final int mMonth;
+
+    /**
+     * The day
+     */
+    private final int mDay;
 
     /**
      * Constructs a timezone-nonspecific DateOnly
      *
      * @param dateStr date string of the form <code>yyyy-mm-dd</code>
+     * @return the parsed DateOnly instance
+     * @exception ParseException If there was a failure parsing the dateStr
      */
-    public static DateOnly parse(String dateStr) throws ParseException {
+    public static DateOnly parse(final String dateStr) throws ParseException {
         // break the date up into its constituent parts
         String[] dateInfo = dateStr.split("-");
 
-        // validate our split datestring
-        if (dateInfo.length != 3) {
+        // validate the split date string
+        final int expectedLength = 3;
+        if (dateInfo.length != expectedLength) {
             throw new ParseException(
                     "Expected datestring format 'yyyy-mm-dd' but found: " + dateStr, 0
             );
@@ -50,7 +63,7 @@ public static DateOnly parse(String dateStr) throws ParseException {
      * @param month 1-indexed month value (Jan == 1)
      * @param day   day of the month
      */
-    public DateOnly(int year, int month, int day) {
+    public DateOnly(final int year, final int month, final int day) {
         mYear = year;
         mMonth = month;
         mDay = day;

graphsdk/src/main/java/com/microsoft/graph/serializer/DateOnlySerializer.java

@@ -128,26 +128,28 @@ public byte[] deserialize(final JsonElement json,
 
         final JsonSerializer<DateOnly> dateJsonSerializer = new JsonSerializer<DateOnly>() {
             @Override
-            public JsonElement serialize(DateOnly src, Type typeOfSrc, JsonSerializationContext context) {
+            public JsonElement serialize(final DateOnly src,
+                                         final Type typeOfSrc,
+                                         final JsonSerializationContext context) {
                 if (src == null) {
                     return null;
                 }
-                return new JsonPrimitive(DateOnlySerializer.serialize(src));
+                return new JsonPrimitive(src.toString());
             }
         };
 
         final JsonDeserializer<DateOnly> dateJsonDeserializer = new JsonDeserializer<DateOnly>() {
             @Override
-            public DateOnly deserialize(JsonElement json,
-                                        Type typeOfT,
-                                        JsonDeserializationContext context) throws JsonParseException {
+            public DateOnly deserialize(final JsonElement json,
+                                        final Type typeOfT,
+                                        final JsonDeserializationContext context) throws JsonParseException {
                 if (json == null) {
                     return null;
                 }
 
                 try {
-                    return DateOnlySerializer.deserialize(json.getAsString());
-                } catch (ParseException e) {
+                    return DateOnly.parse(json.getAsString());
+                } catch (final ParseException e) {
                     logger.logError("Parsing issue on " + json.getAsString(), e);
                     return null;
                 }