simple-websocket and gunicorn

[maybephilipp]

Hello everyone!

Could someone please explain why gunicorn is excluded from support of simple-websocket? I see when simple-websocket support was implemented, gunicorn was restricted: this commit src/engineio/async_drivers/_websocket_wsgi.py, line 16-17

1. Why?
2. Could we plan adding a note about that in docs, and, if applicable, change docs regarding usage with Gevent and Gunicorn: https://python-socketio.readthedocs.io/en/stable/server.html#gevent

Thank you for your work!

[miguelgrinberg]

I don't understand this. Gunicorn works fine with simple-websocket. The threaded, eventlet and gevent workers in Gunicorn all should work. What did you see in that commit that suggests this is not implemented? If you refer to the StopIteration exception, that is actually required by Gunicorn, it is not intended to prevent Gunicorn from being used, but to ensure that it works well.

[maybephilipp]

I feel stupid, thank you for explanation! I didn't know that gunicorn requires this trick

[maybephilipp]

And regarding docs update, should I raise this question in SocketIO repository? Or create an issue?

Currently the documentation still states that for websocket support with Gevent, I need to use gevent-websocket. Same for Gevent + Gunicorn.

https://python-socketio.readthedocs.io/en/stable/server.html#gevent

[miguelgrinberg]

Yes, please write an issue (not a discussion) so that I don't forget to update the docs. Thanks.