Skip to content

Commit df2ec76

Browse files
jgunthorpetorvalds
authored andcommitted
mm/mmu_notifiers: use the right return code for WARN_ON
The return code from the op callback is actually in _ret, while the WARN_ON was checking ret which causes it to misfire. Link: http://lkml.kernel.org/r/20191025175502.GA31127@ziepe.ca Fixes: 8402ce6 ("mm/mmu_notifiers: check if mmu notifier callbacks are allowed to fail") Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent e74540b commit df2ec76

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/mmu_notifier.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range)
180180
mn->ops->invalidate_range_start, _ret,
181181
!mmu_notifier_range_blockable(range) ? "non-" : "");
182182
WARN_ON(mmu_notifier_range_blockable(range) ||
183-
ret != -EAGAIN);
183+
_ret != -EAGAIN);
184184
ret = _ret;
185185
}
186186
}

0 commit comments

Comments
 (0)