Skip to content

Commit 4ccf742

Browse files
Revert ":sparkles: add job information to inference"
This reverts commit 4c80a12.
1 parent 4c80a12 commit 4ccf742

12 files changed

Lines changed: 18 additions & 96 deletions

File tree

lib/mindee/parsing/v2/inference.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# frozen_string_literal: true
22

3-
require_relative 'inference_job'
43
require_relative 'inference_model'
54
require_relative 'inference_file'
65
require_relative 'inference_result'
@@ -13,8 +12,6 @@ module V2
1312
class Inference
1413
# @return [String] Identifier of the inference (when provided by API).
1514
attr_reader :id
16-
# @return [InferenceJob] Metadata about the job.
17-
attr_reader :job
1815
# @return [InferenceModel] Information about the model used.
1916
attr_reader :model
2017
# @return [InferenceFile] Information about the processed file.
@@ -29,7 +26,6 @@ def initialize(server_response)
2926
raise ArgumentError, 'server_response must be a Hash' unless server_response.is_a?(Hash)
3027

3128
@model = InferenceModel.new(server_response['model'])
32-
@job = InferenceJob.new(server_response['job']) if server_response.key?('job')
3329
@file = InferenceFile.new(server_response['file'])
3430
@active_options = InferenceActiveOptions.new(server_response['active_options'])
3531
@result = InferenceResult.new(server_response['result'])
@@ -43,7 +39,6 @@ def to_s
4339
[
4440
'Inference',
4541
'#########',
46-
@job.to_s,
4742
@model.to_s,
4843
@file.to_s,
4944
@active_options.to_s,

lib/mindee/parsing/v2/inference_job.rb

Lines changed: 0 additions & 25 deletions
This file was deleted.

lib/mindee/parsing/v2/job.rb

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@ module V2
1111
class Job
1212
# @return [String] Unique job identifier.
1313
attr_reader :id
14-
# @return [DateTime] Timestamp of creation.
14+
# @return [DateTime, nil] Timestamp of creation.
1515
attr_reader :created_at
16-
# @return [DateTime, nil] Timestamp of job completion.
17-
attr_reader :completed_at
1816
# @return [String] Identifier of the model used.
1917
attr_reader :model_id
2018
# @return [String] Name of the processed file.
@@ -32,7 +30,6 @@ class Job
3230
# @return [ErrorResponse, nil] Error details when the job failed.
3331
attr_reader :error
3432

35-
# rubocop:disable Metrics/CyclomaticComplexity
3633
# @param server_response [Hash] Parsed JSON payload from the API.
3734
def initialize(server_response)
3835
raise ArgumentError, 'server_response must be a Hash' unless server_response.is_a?(Hash)
@@ -42,10 +39,7 @@ def initialize(server_response)
4239
unless server_response['error'].nil? || server_response['error'].empty?
4340
@error = ErrorResponse.new(server_response['error'])
4441
end
45-
@created_at = Time.iso8601(server_response['created_at'])
46-
if server_response.key?('completed_at') && !server_response['completed_at'].nil?
47-
@completed_at = Time.iso8601(server_response['completed_at'])
48-
end
42+
@created_at = Time.iso8601(server_response['created_at'])
4943
@model_id = server_response['model_id']
5044
@polling_url = server_response['polling_url']
5145
@filename = server_response['filename']
@@ -56,7 +50,6 @@ def initialize(server_response)
5650
@webhooks.push JobWebhook.new(webhook)
5751
end
5852
end
59-
# rubocop:enable Metrics/CyclomaticComplexity
6053

6154
# String representation.
6255
# @return [String]

sig/mindee/parsing/v2/inference.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ module Mindee
33
module Parsing
44
module V2
55
class Inference
6-
76
attr_reader id: String
8-
attr_reader job: InferenceJob
97
attr_reader model: InferenceModel
108
attr_reader file: InferenceFile
119
attr_reader active_options: InferenceActiveOptions

sig/mindee/parsing/v2/inference_job.rbs

Lines changed: 0 additions & 12 deletions
This file was deleted.

sig/mindee/parsing/v2/job.rbs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ module Mindee
44
module V2
55
class Job
66
attr_reader alias: String
7-
attr_reader created_at: Time
8-
attr_reader completed_at: Time?
7+
attr_reader created_at: DateTime?
98
attr_reader error: ErrorResponse?
109
attr_reader filename: String
1110
attr_reader id: String

spec/v2/client_v2_integration.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,7 @@
219219

220220
context 'A Data Schema Override' do
221221
it 'Overrides successfully' do
222-
data_schema_replace = File.read(File.join(V2_DATA_DIR, 'products', 'extraction',
223-
'data_schema_replace_param.json'))
222+
data_schema_replace = File.read(File.join(V2_DATA_DIR, 'inference', 'data_schema_replace_param.json'))
224223
input = Mindee::Input::Source::PathInputSource.new(File.join(FILE_TYPES_DIR, 'pdf', 'blank_1.pdf'))
225224

226225
inference_params = Mindee::Input::InferenceParameters.new(

spec/v2/client_v2_spec.rb

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -89,29 +89,6 @@ def stub_next_request_with(method, hash:, status_code: 0)
8989
resp = client.get_job('123e4567-e89b-12d3-a456-426614174000')
9090
expect(resp).to be_a(Mindee::Parsing::V2::JobResponse)
9191
expect(resp.job.status).to eq('Processing')
92-
expect(
93-
resp.job.created_at.strftime('%Y-%m-%dT%H:%M:%S.%6N')
94-
).to eq('2025-07-03T14:27:58.974451')
95-
expect(resp.job.completed_at).to be_nil
96-
end
97-
98-
it 'should deserialize a job properly' do
99-
json_path = File.join(V2_DATA_DIR, 'job', 'ok_processed_webhooks_ok.json')
100-
parsed = File.read(json_path)
101-
stub_next_request_with(:inference_job_req_get, hash: parsed, status_code: 200)
102-
103-
resp = client.get_job('123e4567-e89b-12d3-a456-426614174000')
104-
expect(resp).to be_a(Mindee::Parsing::V2::JobResponse)
105-
expect(resp.job.status).to eq('Processed')
106-
expect(resp.job.model_id).to eq('87654321-4321-4321-4321-CBA987654321')
107-
expect(resp.job.filename).to eq('default_sample.jpg')
108-
expect(resp.job.alias).to eq('dummy-alias.jpg')
109-
expect(
110-
resp.job.created_at.strftime('%Y-%m-%dT%H:%M:%S.%6N')
111-
).to eq('2026-04-20T18:27:58.974451')
112-
expect(
113-
resp.job.completed_at.strftime('%Y-%m-%dT%H:%M:%S.%6N')
114-
).to eq('2026-04-20T18:32:02.734312')
11592
end
11693
ENV.delete('MINDEE_V2_BASE_URL')
11794
end

spec/v2/input/inference_parameter_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
require 'mindee/input/data_schema'
55

66
describe Mindee::Input::InferenceParameters do
7-
let(:extracted_schema_content) do
8-
File.read(File.join(V2_DATA_DIR, 'products', 'extraction', 'data_schema_replace_param.json'))
9-
end
7+
let(:extracted_schema_content) { File.read(File.join(V2_DATA_DIR, 'inference', 'data_schema_replace_param.json')) }
108
let(:extracted_schema_hash) { JSON.parse(extracted_schema_content) }
119
let(:extracted_schema_str) { extracted_schema_hash.to_json }
1210
let(:extracted_schema_object) { Mindee::Input::DataSchema.new(extracted_schema_hash) }

0 commit comments

Comments
 (0)