Skip to content

Commit 173f7e2

Browse files
mingdeyumingdeyu
committed
Update cran-comments.md
1 parent 1776822 commit 173f7e2

1 file changed

Lines changed: 22 additions & 76 deletions

File tree

‎cran-comments.md‎

Lines changed: 22 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,6 @@
1-
# Resubmission
2-
This is a resubmission. Following the comments (see below) from CRAN in the first submission, various changes (see responses below) have been made in this version (`2.1.5`).
1+
This is the submission of 'dgpsi' 2.1.6.
32

4-
## Responses to comments from CRAN
5-
6-
- Comment 1:
7-
8-
**CRAN**: Please omit the redundant "R" at the start of your title and the description.
9-
10-
**Maintainer's Response**: Done.
11-
12-
- Comment 2:
13-
14-
**CRAN**: Please always write package names, software names and API (application programming interface) names in single quotes in title and description. e.g: --> 'python' Please note that package names are case sensitive.
15-
16-
**Maintainer's Response**: All package names, software names, and API mentioned in title and description are now in single quotes.
17-
18-
- Comment 3:
19-
20-
**CRAN**: Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation. Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar).
21-
22-
Missing Rd-tags:
23-
* init_py.Rd: \arguments, \value
24-
* trace_plot.Rd: \value
25-
* write.Rd: \value
26-
27-
**Maintainer's Response**: All exported methods now have \arguments and \value in their .Rd files. The structure of the output (class) from exported methods are now all carefully explained.
28-
29-
- Comment 4:
30-
31-
**CRAN**: Please add small executable examples in your Rd-files to illustrate the use of the exported function but also enable automatic testing.
32-
33-
**Maintainer's Response**: Small examples are added to key functions `gp()`, `dgp()`, and `lgp()` of the package. Since the examples involve the implementations of other exported functions, we did not repeat the same examples in different Rd-files. Instead, we highlight in `Examples` sections of other exported functions that their usages can be found in `Examples` sections of `gp()`, `dgp()`, and `lgp()`. Since the package depends on the underlying 'python' implementation, the added small examples are wrapped in `\dontrun{}`, following other similar packages, such as [`{reticulate}`](https://github.com/rstudio/reticulate), [`{keras}`](https://github.com/rstudio/keras), etc. All small examples were carefully tested before being included in Rd-files.
3+
Various updates have been made in this version. A detailed list of changes that have been made since the last version 2.1.5 is contained in NEWS.md.
344

355
## Test environments
366

@@ -40,27 +10,39 @@ This is a resubmission. Following the comments (see below) from CRAN in the firs
4010
- GitHub Actions: ubuntu-latest (devel)
4111
- GitHub Actions: ubuntu-latest (release)
4212
- GitHub Actions: ubuntu-latest (oldrel-1)
13+
- win-builder: windows-x86_64-w64-mingw32 (r-devel)
14+
- win-builder: windows-x86_64-w64-mingw32 (r-release)
4315
- R-Hub: windows-x86_64-devel (r-devel)
44-
- R-Hub: ubuntu-gcc-release (r-release)
4516
- R-Hub: fedora-clang-devel (r-devel)
46-
- win-builder: windows-x86_64-w64-mingw32 (r-devel)
4717

4818
## R CMD check results
4919

5020
- There were no ERRORs, WARNINGs and NOTEs on Local Test and GitHub Actions.
5121

52-
- There were no ERRORs, WARNINGs and 5 NOTEs on R-Hub:
22+
- There were no ERRORs, WARNINGs and 1 NOTE on win-builder:
5323

54-
* On windows-x86_64-devel (r-devel)
55-
24+
* On windows-x86_64-w64-mingw32 (r-release)
25+
5626
```
57-
checking CRAN incoming feasibility ... [21s] NOTE
27+
* checking CRAN incoming feasibility ... NOTE
5828
Maintainer: 'Deyu Ming <deyu.ming.16@ucl.ac.uk>'
5929
60-
New submission
30+
Found the following (possibly) invalid URLs:
31+
URL: https://doi.org/10.1137/20M1323771
32+
From: README.md
33+
Status: 403
34+
Message: Forbidden
35+
36+
Found the following (possibly) invalid DOIs:
37+
DOI: 10.1137/20M1323771
38+
From: DESCRIPTION
39+
Status: Forbidden
40+
Message: 403
6141
```
42+
43+
**Maintainer's Comment**: Both the URL and DOI in the note are valid and can be accessed correctly. This note did not appear in any other R CMD checks. Thus, this note can be safely ignored.
6244
63-
**Maintainer's Comment**: New submission. This note can be safely ignored.
45+
- There were no ERRORs, WARNINGs and 2 NOTEs on R-Hub:
6446
6547
* On windows-x86_64-devel (r-devel)
6648
@@ -72,28 +54,6 @@ This is a resubmission. Following the comments (see below) from CRAN in the firs
7254
7355
**Maintainer's Comment**: This note only appeared in this build. It did not appear in any other builds. In addition, As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX. Thus, this note can be likely ignored.
7456
75-
* On ubuntu-gcc-release (r-release)
76-
77-
```
78-
checking CRAN incoming feasibility ... NOTE
79-
Maintainer: ‘Deyu Ming <deyu.ming.16@ucl.ac.uk>’
80-
81-
New submission
82-
```
83-
84-
**Maintainer's Comment**: New submission. This note can be safely ignored.
85-
86-
* On fedora-clang-devel (r-devel)
87-
88-
```
89-
checking CRAN incoming feasibility ... [7s/23s] NOTE
90-
Maintainer: ‘Deyu Ming <deyu.ming.16@ucl.ac.uk>’
91-
92-
New submission
93-
```
94-
95-
**Maintainer's Comment**: New submission. This note can be safely ignored.
96-
9757
* On fedora-clang-devel (r-devel)
9858
9959
```
@@ -102,17 +62,3 @@ This is a resubmission. Following the comments (see below) from CRAN in the firs
10262
```
10363
10464
**Maintainer's Comment**: Not sure about the cause of this note. Some relevant discussions are give [here](https://groups.google.com/g/r-sig-mac/c/7u_ivEj4zhM) and it seems that the test Server does not have `tidy` installed. This note only appeared in this build, and did not appear in any other builds. Thus, this note can be likely ignored.
105-
106-
- There were no ERRORs, WARNINGs and 1 NOTE on win-builder:
107-
108-
```
109-
checking CRAN incoming feasibility ... [10s] NOTE
110-
Maintainer: 'Deyu Ming <deyu.ming.16@ucl.ac.uk>'
111-
112-
New submission
113-
114-
Possibly misspelled words in DESCRIPTION:
115-
Guillas (15:56, 16:34)
116-
```
117-
118-
**Maintainer's Comment**: The note on New submission can be safely ignored. The possible misspelled word "Guillas" is the surname of a co-author of articles cited in DESCRIPTION. This note did not appear in any other R CMD checks because `.aspell/` directory has been created under the package root to mitigate this note as per instructions given [here](http://dirk.eddelbuettel.com/blog/2017/08/10/#008_aspell_cran_incoming) and examples given in [`{edmdata}`](https://github.com/tmsalab/edmdata). Thus, this note can be safely ignored.

0 commit comments

Comments
 (0)