Merge pull request #158 from alexpott/move-to-github-actions

Move to GitHub Actions and bump minimum PHP to 5.4

Author: stof

.github/workflows/tests.yml

@@ -0,0 +1,75 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+
+  tests:
+    name: Tests (PHP ${{ matrix.php }} ${{ matrix.minimum_stability }}, Symfony LTS ${{ matrix.symfony_lts }})
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        php: [ '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1' ]
+        minimum_stability: [ 'stable' ]
+        symfony_lts: [ false ]
+        include:
+          - php: '8.0'
+            minimum_stability: dev
+          - php: '7.4'
+            minimum_stability: dev
+          - php: '7.2'
+            symfony_lts: '^2'
+          - php: '7.2'
+            symfony_lts: '^3'
+      fail-fast: false
+
+    env:
+      MATRIX_PHP: ${{ matrix.php }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          coverage: "xdebug"
+          php-version: "${{ matrix.php }}"
+          tools: composer
+
+      - name: Configure for minimum stability
+        if: "${{ matrix.minimum_stability == 'dev' }}"
+        run: |
+          composer config minimum-stability dev
+
+      - name: Configure for Symfony LTS version
+        if: "${{ matrix.symfony_lts != false }}"
+        run: |
+          composer require -n --no-update symfony/lts=${{ matrix.symfony_lts }}
+
+      - name: Configure for PHP >= 7.1
+        if: "${{ matrix.php >= '7.1' && matrix.symfony_lts == false }}"
+        run: |
+          composer require --no-update --dev symfony/error-handler "^4.4 || ^5.0"
+
+      - name: Install dependencies
+        run: |
+          composer update --no-interaction --prefer-dist
+
+      - name: Run tests
+        run: |
+          vendor/bin/phpunit -v --coverage-clover=coverage.clover
+
+      - name: Upload code coverage
+        if: "${{ matrix.php > '5.4' && matrix.symfony_lts == false }}"
+        run: |
+          composer require scrutinizer/ocular
+          vendor/bin/ocular code-coverage:upload --repository=g/minkphp/MinkBrowserKitDriver --format=php-clover coverage.clover

.gitignore

@@ -1,3 +1,4 @@
 vendor
 composer.lock
 /phpunit.xml
+.phpunit.result.cache

.travis.yml

@@ -15,7 +15,7 @@
     ],
 
     "require": {
-        "php":                  ">=5.3.6",
+        "php":                  ">=5.4",
         "behat/mink":           "^1.7.1@dev",
         "symfony/browser-kit":  "~2.3|~3.0|~4.0",
         "symfony/dom-crawler":  "~2.3|~3.0|~4.0"
@@ -24,7 +24,9 @@
     "require-dev": {
         "mink/driver-testsuite": "dev-master",
         "symfony/debug": "^2.7|^3.0|^4.0",
-        "symfony/http-kernel": "~2.3|~3.0|~4.0"
+        "symfony/http-kernel": "~2.3|~3.0|~4.0",
+        "phpunit/phpunit": "^4.8.36 || ^5.7.27 || ^6.5.14 || ^7.5.18 || ^8.5 || ^9.5",
+        "yoast/phpunit-polyfills": "^1.0"
     },
 
     "autoload": {

composer.json

@@ -44,9 +44,7 @@ public function skipMessage($testCase, $test)
                 'testHtml5FormAction',
                 'testHtml5FormMethod',
             ))
-            && !method_exists('Symfony\Component\DomCrawler\Tests\FormTest', 'testGetMethodWithOverride')
-            // Symfony 4.4 removed tests from dist archives, making the previous detection return a false-positive
-            && !method_exists('Symfony\Component\DomCrawler\Form', 'getName')
+            && !class_exists('\Symfony\Component\DomCrawler\AbstractUriElement')
         ) {
             return 'Mink BrowserKit doesn\'t support HTML5 form attributes before Symfony 3.3';
         }

tests/BrowserKitConfig.php

@@ -6,15 +6,21 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\BrowserKit\Client;
 use Symfony\Component\BrowserKit\Response;
+use Yoast\PHPUnitPolyfills\Polyfills\ExpectException;
 
 class ErrorHandlingTest extends TestCase
 {
+    use ExpectException;
+
     /**
      * @var TestClient
      */
     private $client;
 
-    protected function setUp()
+    /**
+     * @before
+     */
+    protected function prepareClient()
     {
         $this->client = new TestClient();
     }
@@ -25,50 +31,45 @@ public function testGetClient()
     }
 
     /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage Unable to access the response before visiting a page
-     *
      * Looks like we have to mark these tests as "legacy", otherwise we get deprecation errors.
      * Although the deprecations are handled, there's no way to avoid the deprecation message here.
      * @group legacy
      */
     public function testGetResponseHeaderWithoutVisit()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('Unable to access the response before visiting a page');
         $this->getDriver()->getResponseHeaders();
     }
 
     /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage Unable to access the response content before visiting a page
-     *
      * Looks like we have to mark these tests as "legacy", otherwise we get deprecation errors.
      * Although the deprecations are handled, there's no way to avoid the deprecation message here.
      * @group legacy
      */
     public function testFindWithoutVisit()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('Unable to access the response content before visiting a page');
         $this->getDriver()->find('//html');
     }
 
     /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage Unable to access the request before visiting a page
-     *
      * Looks like we have to mark these tests as "legacy", otherwise we get deprecation errors.
      * Although the deprecations are handled, there's no way to avoid the deprecation message here.
      * @group legacy
      */
     public function testGetCurrentUrlWithoutVisit()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('Unable to access the request before visiting a page');
         $this->getDriver()->getCurrentUrl();
     }
 
-    /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage The selected node has an invalid form attribute (foo)
-     */
     public function testNotMatchingHtml5FormId()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('The selected node has an invalid form attribute (foo)');
         $html = <<<'HTML'
 <html>
 <body>
@@ -87,12 +88,10 @@ public function testNotMatchingHtml5FormId()
         $driver->setValue('//input[./@name="test"]', 'bar');
     }
 
-    /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage The selected node has an invalid form attribute (foo)
-     */
     public function testInvalidHtml5FormId()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('The selected node has an invalid form attribute (foo)');
         $html = <<<'HTML'
 <html>
 <body>
@@ -112,12 +111,10 @@ public function testInvalidHtml5FormId()
         $driver->setValue('//input[./@name="test"]', 'bar');
     }
 
-    /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage The selected node does not have a form ancestor.
-     */
     public function testManipulateInputWithoutForm()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('The selected node does not have a form ancestor.');
         $html = <<<'HTML'
 <html>
 <body>
@@ -138,12 +135,10 @@ public function testManipulateInputWithoutForm()
         $driver->setValue('//input[./@name="test"]', 'bar');
     }
 
-    /**
-     * @expectedException \Behat\Mink\Exception\DriverException
-     * @expectedExceptionMessage Behat\Mink\Driver\BrowserKitDriver supports clicking on links and submit or reset buttons only. But "div" provided
-     */
     public function testClickOnUnsupportedElement()
     {
+        $this->expectException('\Behat\Mink\Exception\DriverException');
+        $this->expectExceptionMessage('Behat\Mink\Driver\BrowserKitDriver supports clicking on links and submit or reset buttons only. But "div" provided');
         $html = <<<'HTML'
 <html>
 <body>