Merge pull request #323 from mvorisek/allow_only_expr

aik099 · web-flow · commit d7622bf28722 · 2020-08-29T17:36:42.000+03:00
Condition can be an expression only
diff --git a/src/Selenium2Driver.php b/src/Selenium2Driver.php
@@ -972,7 +972,7 @@ public function evaluateScript($script)
      */
     public function wait($timeout, $condition)
     {
-        $script = "return $condition;";
+        $script = 'return (' . $condition . ');';
         $start = microtime(true);
         $end = $start + $timeout / 1000.0;
 

Original file line number	Diff line number	Diff line change
`@@ -972,7 +972,7 @@ public function evaluateScript($script)`
`972`	`972`	`*/`
`973`	`973`	`public function wait($timeout, $condition)`
`974`	`974`	`{`
`975`		`- $script = "return $condition;";`
	`975`	`+ $script = 'return (' . $condition . ');';`
`976`	`976`	`$start = microtime(true);`
`977`	`977`	`$end = $start + $timeout / 1000.0;`
`978`	`978`