Merge pull request #86 from stof/remove_invalid_test

Remove tests enforcing a DriverException for null values in setValue

Author: stof

tests/Form/GeneralTest.php

@@ -368,18 +368,17 @@ public function testSetInvalidValueInField(string $field, $value): void
 
     public static function provideInvalidValues(): iterable
     {
-        $nullValue = ['null', null];
         $trueValue = ['true', true];
         $falseValue = ['false', false];
         $arrayValue = ['array', ['bad']];
         $stringValue = ['string', 'updated'];
 
         $scenarios = [
             // field type, name or id, list of values to check
-            ['file', 'about', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['textarea', 'notes', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['text', 'first_name', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['button', 'submit', [$nullValue, $trueValue, $falseValue, $arrayValue, $stringValue]],
+            ['file', 'about', [$trueValue, $falseValue, $arrayValue]],
+            ['textarea', 'notes', [$trueValue, $falseValue, $arrayValue]],
+            ['text', 'first_name', [$trueValue, $falseValue, $arrayValue]],
+            ['button', 'submit', [$trueValue, $falseValue, $arrayValue, $stringValue]],
         ];
 
         foreach ($scenarios as [$fieldType, $fieldNameOrId, $values]) {

tests/Form/Html5Test.php

@@ -179,20 +179,19 @@ public function testSetInvalidValueInField(string $field, $value): void
 
     public static function provideInvalidValues(): iterable
     {
-        $nullValue = ['null', null];
         $trueValue = ['true', true];
         $falseValue = ['false', false];
         $arrayValue = ['empty array', []];
 
         $scenarios = [
             // field type, name or id, list of values to check
-            ['url', 'url', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['email', 'email', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['number', 'number', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['search', 'search', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['color', 'color', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['date', 'date', [$nullValue, $trueValue, $falseValue, $arrayValue]],
-            ['time', 'time', [$nullValue, $trueValue, $falseValue, $arrayValue]],
+            ['url', 'url', [$trueValue, $falseValue, $arrayValue]],
+            ['email', 'email', [$trueValue, $falseValue, $arrayValue]],
+            ['number', 'number', [$trueValue, $falseValue, $arrayValue]],
+            ['search', 'search', [$trueValue, $falseValue, $arrayValue]],
+            ['color', 'color', [$trueValue, $falseValue, $arrayValue]],
+            ['date', 'date', [$trueValue, $falseValue, $arrayValue]],
+            ['time', 'time', [$trueValue, $falseValue, $arrayValue]],
         ];
 
         foreach ($scenarios as [$fieldType, $fieldNameOrId, $values]) {