Merge pull request #69 from stof/deprecate_skipped_unsupported

stof · web-flow · commit f9033515e82d · 2023-06-09T12:49:23.000+02:00
Deprecate marking tests as skipped for unsupported actions
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -74,6 +74,7 @@ protected function resetSessions()
     protected function onNotSuccessfulTest(\Throwable $e): void
     {
         if ($e instanceof UnsupportedDriverActionException) {
+            @trigger_error(sprintf('Relying on catching "UnsupportedDriverActionException" to mark tests as skipped is deprecated. The test "%s::%s" should be marked as skipped through the test config.', get_class($this), $this->getName(false)), E_USER_DEPRECATED);
             $this->markTestSkipped($e->getMessage());
         }
 

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ protected function resetSessions()`
`74`	`74`	`protected function onNotSuccessfulTest(\Throwable $e): void`
`75`	`75`	`{`
`76`	`76`	`if ($e instanceof UnsupportedDriverActionException) {`
	`77`	`+ @trigger_error(sprintf('Relying on catching "UnsupportedDriverActionException" to mark tests as skipped is deprecated. The test "%s::%s" should be marked as skipped through the test config.', get_class($this), $this->getName(false)), E_USER_DEPRECATED);`
`77`	`78`	`$this->markTestSkipped($e->getMessage());`
`78`	`79`	`}`
`79`	`80`