Skip to content

Commit 0be0ba6

Browse files
authored
Merge pull request #131 from aik099/remove-session-proxy
Removed the "SessionProxy" class
2 parents 1054f33 + b641d94 commit 0be0ba6

5 files changed

Lines changed: 16 additions & 50 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1616
- Reduce memory consumption by rewriting `SessionStrategyFactory` and `SessionStrategyManager` classes.
1717
- (Not a BC break) Some public methods of the `BrowserTestCase` class are protected now. Affected methods: `setRemoteCoverageScriptUrl`, `setBrowser`, `getBrowser`, `setSessionStrategy`, `getSessionStrategy`, `getCollectCodeCoverageInformation`, `getRemoteCodeCoverageInformation`.
1818
- (Not a BC break) Some protected properties of the `BrowserTestCase` class are private now. Affected properties: `sessionStrategyManager`, `remoteCoverageHelper`, `sessionStrategy`.
19+
- Bumped minimal required `Behat/Mink` version to 1.8 (needed after `SessionProxy` class removal).
1920

2021
### Fixed
2122
- Don't set remote code coverage collection cookies, when the remote code coverage script URL isn't specified.

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
"require": {
1616
"php": ">=5.6",
17-
"behat/mink": "~1.6@dev",
17+
"behat/mink": "^1.8@dev",
1818
"behat/mink-selenium2-driver": "~1.2",
1919
"phpunit/phpunit": ">=4.8.35 <5|>=5.4.3",
2020
"console-helpers/phpunit-compat": "^1.0.2"

composer.lock

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

library/aik099/PHPUnit/Session/SessionFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class SessionFactory implements ISessionFactory
3131
*/
3232
public function createSession(BrowserConfiguration $browser)
3333
{
34-
return new SessionProxy($browser->createDriver());
34+
return new Session($browser->createDriver());
3535
}
3636

3737
}

library/aik099/PHPUnit/Session/SessionProxy.php

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)