Skip to content

Commit f8524d7

Browse files
mivertowskiclaude
andcommitted
fix(ci): switch toolchain from nightly to stable for CI compatibility
Root cause of persistent Clippy failures: - rust-toolchain.toml pinned to nightly (required for portable_simd feature) - CI dtolnay/rust-toolchain@stable was being overridden by the toml - Nightly's newer future-compat lints (f32: From<f64> fallback, etc.) were firing under -D warnings Changes: 1. rust-toolchain.toml: nightly -> stable 2. ringkernel-wavesim: remove 'simd' from default features (requires nightly) Users on nightly can opt in with --features simd 3. commands/codegen.rs: collapse if-inside-match to guard pattern SIMD feature still works — just not enabled by default. This matches the v1.0.0 principle: ship what works on stable without surprises. 1483 tests pass, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent de3b3df commit f8524d7

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

crates/ringkernel-cli/src/commands/codegen.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,8 @@ fn parse_ring_kernel_attr(attr: &syn::Attribute, fn_name: &syn::Ident) -> (Strin
190190
_ => {}
191191
}
192192
}
193-
syn::Lit::Int(i) => {
194-
if key == "block_size" {
195-
block_size = i.base10_parse().unwrap_or(256);
196-
}
193+
syn::Lit::Int(i) if key == "block_size" => {
194+
block_size = i.base10_parse().unwrap_or(256);
197195
}
198196
_ => {}
199197
}

crates/ringkernel-wavesim/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ syn = { workspace = true, optional = true }
4949
criterion = { workspace = true }
5050

5151
[features]
52-
default = ["cpu", "simd"]
52+
default = ["cpu"]
5353
cpu = ["ringkernel/cpu"]
5454
cuda = ["ringkernel/cuda", "dep:ringkernel-cuda", "dep:cudarc", "dep:bytemuck"]
5555
cuda-codegen = ["cuda", "dep:ringkernel-cuda-codegen", "dep:syn", "ringkernel-derive/cuda-codegen"]
56-
simd = [] # Enable SIMD optimizations (requires nightly)
56+
simd = [] # Enable SIMD optimizations (requires nightly Rust, opt-in only)
5757

5858
[[bin]]
5959
name = "wavesim"

rust-toolchain.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[toolchain]
2-
channel = "nightly"
2+
channel = "stable"
33
components = ["rustfmt", "clippy"]

0 commit comments

Comments
 (0)