Fix clippy warnings and address security vulnerabilities

Clippy fixes:
- persistent_fdtd.rs: Remove useless format!() on static string
- profile.rs: Replace redundant closure with tuple variant (CliError::Validation)
- profile.rs: Replace map_or(false, ...) with is_some_and(...)
- profile.rs: Remove unnecessary .to_string() in format args for emojis

Security fixes:
- Update prometheus from 0.13 to 0.14 with default-features = false
  This removes the protobuf dependency which had GHSA-2gh3-rmm4-6rq5

Remaining security notes:
- lru v0.12.5 (GHSA-rhfx-m35p-ff5j) via iced 0.13 - requires iced 0.14
  migration with breaking API changes (tracked for future release)
- lexical-core v1.0.6 is SAFE (vulnerability was < 1.0.0)
- fast-float alerts are false positives (we use fast-float2)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: mivertowski

Cargo.lock

@@ -165,7 +165,7 @@ pub async fn execute(
     output: Option<&str>,
     detailed: bool,
 ) -> CliResult<()> {
-    let output_format = OutputFormat::from_str(format).map_err(|e| CliError::Validation(e))?;
+    let output_format = OutputFormat::from_str(format).map_err(CliError::Validation)?;
 
     let config = ProfileConfig {
         kernel: kernel.to_string(),
@@ -197,7 +197,7 @@ pub async fn execute(
     // Check if kernel file exists (for file-based profiling)
     let kernel_path = Path::new(kernel);
     let is_file_based =
-        kernel_path.exists() && kernel_path.extension().map_or(false, |e| e == "rs");
+        kernel_path.exists() && kernel_path.extension().is_some_and(|e| e == "rs");
 
     let result = if is_file_based {
         profile_kernel_file(&config).await?
@@ -407,15 +407,15 @@ fn format_text(result: &ProfileResult) -> String {
     ));
     output.push_str(&format!(
         "  {} Profile Results: {}\n",
-        "📊".to_string(),
+        "📊",
         result.kernel_name.bright_white()
     ));
     output.push_str(&format!(
         "{}\n\n",
         "═══════════════════════════════════════════════════════════════".bright_cyan()
     ));
 
-    output.push_str(&format!("  {} Timing Statistics\n", "⏱️".to_string()));
+    output.push_str(&format!("  {} Timing Statistics\n", "⏱️"));
     output.push_str(&format!(
         "    Iterations: {} (+ {} warmup)\n",
         result.iterations.to_string().bright_yellow(),
@@ -455,7 +455,7 @@ fn format_text(result: &ProfileResult) -> String {
     ));
 
     if let Some(ref mem) = result.memory {
-        output.push_str(&format!("  {} Memory Bandwidth\n", "💾".to_string()));
+        output.push_str(&format!("  {} Memory Bandwidth\n", "💾"));
         output.push_str(&format!(
             "    Read:       {:.2} GB/s\n",
             mem.read_bandwidth_gbps

crates/ringkernel-cli/src/commands/profile.rs

@@ -392,7 +392,7 @@ __device__ bool k2h_send(
     );
 
     // Energy reduction function
-    code.push_str(&format!(
+    code.push_str(
         r#"
 // ============================================================================
 // ENERGY CALCULATION (Parallel Reduction)
@@ -404,27 +404,27 @@ __device__ float block_reduce_energy(
     float my_energy,
     float* shared_reduce,
     int threads_per_block
-) {{
+) {
     int tid = threadIdx.x;
 
     // Store initial value in shared memory
     shared_reduce[tid] = my_energy;
     __syncthreads();
 
     // Parallel reduction tree
-    for (int stride = threads_per_block / 2; stride > 0; stride >>= 1) {{
-        if (tid < stride) {{
+    for (int stride = threads_per_block / 2; stride > 0; stride >>= 1) {
+        if (tid < stride) {
             shared_reduce[tid] += shared_reduce[tid + stride];
-        }}
+        }
         __syncthreads();
-    }}
+    }
 
     // Return the total for this block (only thread 0 has final sum)
     return shared_reduce[0];
-}}
+}
 
-"#
-    ));
+"#,
+    );
 
     // Halo exchange functions
     code.push_str(&format!(

crates/ringkernel-cuda-codegen/src/persistent_fdtd.rs

@@ -110,7 +110,7 @@ candle-core = { version = "0.4", optional = true }
 config = { version = "0.14", optional = true, default-features = false, features = ["toml"] }
 
 # Optional: Metrics
-prometheus = { version = "0.13", optional = true }
+prometheus = { version = "0.14", optional = true, default-features = false }
 
 # Optional: Persistent kernel support (enables cuda feature for full functionality)
 ringkernel-cuda = { workspace = true, optional = true, features = ["cuda"] }