chore: use rollup/vite plugin to deal with deps and builtins in bundle

Author: Mike Valeriano

biome.jsonc

@@ -48,6 +48,21 @@
     }
   },
   "overrides": [
+    {
+      // TODO: check later
+      // noUnresolvedImports not working properly, flags node builtins
+      // useExplicitType breaking type inference
+      "includes": ["**/*"],
+      "linter": {
+        "rules": {
+          "nursery": {
+            "noUnresolvedImports": "off",
+            "useExplicitType": "off"
+          }
+        }
+      }
+    },
+
     {
       // test files, config files, and some scripts
       // export defaults from them, and also import from node

package-lock.json

@@ -35,6 +35,7 @@
     "@commitlint/config-conventional": "^19.8.1",
     "@types/node": "^24.0.3",
     "husky": "^9.1.7",
+    "rollup-plugin-node-externals": "^8.0.1",
     "tsx": "^4.20.3",
     "typescript": "^5.8.3",
     "vite": "^6.3.5"

package.json

@@ -1,7 +1,7 @@
 import { glob } from "node:fs/promises";
 import { fileURLToPath } from "node:url";
+import { nodeExternals } from "rollup-plugin-node-externals";
 import { defineConfig } from "vite";
-import pkg from "./package.json" with { type: "json" };
 
 const entryFiles: string[] = [];
 for await (const file of glob("src/**/*.ts")) {
@@ -18,45 +18,37 @@ export default defineConfig({
     },
   },
 
-  plugins: [],
+  plugins: [
+    nodeExternals({
+      // packages to be set as internal
+      exclude: ["@mkvlrn/result"],
+    }),
+  ],
 
   build: {
     target: "esnext",
     lib: {
       entry: entryFiles,
       formats: ["es"],
-      // biome-ignore lint/nursery/useExplicitType: not sure
-      fileName: (_format, entryName) => `${entryName}.js`,
+      fileName: (_, entryName) => `${entryName}.js`,
     },
     outDir: "./build",
     emptyOutDir: true,
     rollupOptions: {
-      // biome-ignore lint/nursery/useExplicitType: not sure
-      external: (id) => {
-        // node builtins
-        if (id.startsWith("node:")) {
-          return false;
-        }
-
-        // packages that should be bundled
-        const internals = ["@mkvlrn/result"];
-        if (internals.includes(id)) {
-          return false;
-        }
-
-        // external dependencies
-        if (Object.keys(pkg.dependencies ?? {}).some((dep) => id.startsWith(dep))) {
-          return true;
-        }
-      },
       output: {
         preserveModules: true,
         preserveModulesRoot: "src",
-        // biome-ignore lint/nursery/useExplicitType: not sure
-        entryFileNames: ({ name }) => `${name.replace("node_modules/", "_internals/")}.js`,
+        // this outputs bundled/internal packages to a directory named _internal
+        entryFileNames: ({ name }) => `${name.replace("node_modules/", "_internal/")}.js`,
+      },
+    },
+    minify: "terser",
+    terserOptions: {
+      compress: false,
+      format: {
+        comments: false,
       },
     },
-    minify: false,
   },
 
   optimizeDeps: {