Skip to content

Commit 8b1529d

Browse files
FORWARD: assert invariant for unreachable rref branch in _lead_dots (#13764)
1 parent 49404a3 commit 8b1529d

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

doc/changes/dev/13764.bugfix.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Clarified an internal forward-model invariant in ``mne.forward._lead_dots`` by asserting that ``rref`` is ``None`` on the current code path, by `Pragnya Khandelwal`_.

mne/forward/_lead_dots.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -602,10 +602,5 @@ def _do_surface_dots_subset(
602602
n_fact,
603603
ch_type,
604604
).T
605-
if rref is not None:
606-
raise NotImplementedError # we don't ever use this, isn't tested
607-
# vres = _fast_sphere_dot_r0(
608-
# intrad, rref, rmags, refl, rlens, this_nn, cosmags, None, ws,
609-
# volume, lut, n_fact, ch_type)
610-
# products -= vres
605+
assert rref is None # guaranteed by our code path
611606
return products

0 commit comments

Comments
 (0)