Skip to content

fix: delete logRspBuffer in AbstractDcpManagerSlave destructor#76

Merged
klausschuch merged 1 commit into
modelica:masterfrom
oliverpapst1:fix/log-rsp-buffer-delete
Jun 8, 2026
Merged

fix: delete logRspBuffer in AbstractDcpManagerSlave destructor#76
klausschuch merged 1 commit into
modelica:masterfrom
oliverpapst1:fix/log-rsp-buffer-delete

Conversation

@oliverpapst1

Copy link
Copy Markdown
Contributor

logRspBuffer is allocated in the constructor but never freed in the destructor, causing a 900-byte heap leak on every slave teardown.

Added delete[] logRspBuffer to ~AbstractDcpManagerSlave().

Closes #75.

@oliverpapst1 oliverpapst1 force-pushed the fix/log-rsp-buffer-delete branch from cc13c3d to 3a5934d Compare June 3, 2026 06:58
@klausschuch klausschuch merged commit 1db8ed8 into modelica:master Jun 8, 2026
1 check passed
@klausschuch

Copy link
Copy Markdown
Collaborator

merged
However, I'm still wondering why this seemingly fixed size buffer is even explicitly allocated with new and not just a simple class member in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logRspBuffer not deleted in AbstractDcpManagerSlave destructor

2 participants