Skip to content

Commit 6b23dff

Browse files
authored
chore(copilot): drop repo-specific details from canonical instructions (#116)
## Why Copilot review on [mojwang/ihw#33](mojwang/ihw#33) correctly flagged two bullets in the canonical that leaked mojwang.tech-specific details into the shared file: 1. **Secrets bullet**: prescribed `.env.sync-vault.local` as the required destination for admin DB creds — a mojwang.tech-only convention. 2. **Skip bullet**: hardcoded `src/db/queries/related.ts` and `scripts/sync-vault.ts` (files that only exist in mojwang.tech) as the "AI Gateway migration, Tier 2.1" known-deferral. Both are repo-specific and belong in each repo's own CLAUDE.md or TODO — not in the shared canonical that gets synced fleet-wide. ## What changes ```diff ### Security + safety - ...payment-safety hook... -- Admin DB creds (DATABASE_URL_ADMIN) in .env.local — they belong in .env.sync-vault.local. +- Secrets (API keys, DB admin creds) in committed .env.local or any checked-in env file. Repo-specific env-file conventions live in that repo's CLAUDE.md. ## Skip (don't suggest these) -- AI Gateway migration (Tier 2.1). Direct openai imports in src/db/queries/related.ts, scripts/sync-vault.ts are known and deferred... +- Known, repo-specific deferrals (e.g., "migrate to X", "adopt Y provider"). If a repo has an active deferral, it lives in that repo's CLAUDE.md or a TODO file — do not re-flag it here from a general stance. ``` ## Already synced downstream Re-ran `scripts/sync-copilot-instructions.sh` before this PR. Synced copies have already landed via: - [mojwang/ihw#33](mojwang/ihw#33) — merged - mojwang/mojwang.tech — needs a small sync PR separately This PR brings the canonical into alignment with what's already in the sibling repos. ## Test plan - [x] Copilot's two flagged threads on ihw#33 resolved after sync landed - [x] ihw#33 merged with all seven required status checks green - [ ] mojwang.tech re-sync PR opened as a follow-up
1 parent fe783b7 commit 6b23dff

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/copilot-instructions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Copilot instructions
22

3-
Canonical `.github/copilot-instructions.md` — applies to Copilot code review, Chat, and inline generation in this repo. Synced to sibling repos via `scripts/sync-copilot-instructions.sh`. Single source of truth; edit here, re-sync downstream.
3+
Applies to Copilot code review, Chat, and inline generation. Canonical: `macbook-dev-setup/.github/copilot-instructions.md`; synced to sibling repos via `macbook-dev-setup/scripts/sync-copilot-instructions.sh`. Edit the canonical, then re-sync downstream — the `## Canonical source` section below has the full rationale.
44

55
## Project context
66

@@ -44,7 +44,7 @@ When reviewing a PR, prioritize these concerns in roughly this order.
4444
### Security + safety
4545
- Secrets or API keys in client-bundled code, committed `.env` files, or agent frontmatter.
4646
- `Bash` commands that touch paid services (Stripe, x402, Browserbase, parallel.ai, tempo) without the `CLAUDE_ALLOW_PAYMENTS=1` escape valve — the payment-safety hook exists for a reason.
47-
- Admin DB creds (`DATABASE_URL_ADMIN`) in `.env.local` — they belong in `.env.sync-vault.local`.
47+
- Secrets (API keys, DB admin creds) in committed `.env.local` or any checked-in env file. Repo-specific env-file conventions live in that repo's CLAUDE.md.
4848

4949
## Universal discipline (applies to every repo this file is synced to)
5050

@@ -63,7 +63,7 @@ This file does not prescribe voice. Each repo owns its own tone:
6363

6464
## Skip (don't suggest these)
6565

66-
- **AI Gateway migration** (Tier 2.1). Direct `openai` imports in `src/db/queries/related.ts`, `scripts/sync-vault.ts` are known and deferredstop flagging them as a recommendation.
66+
- **Known, repo-specific deferrals** (e.g., "migrate to X", "adopt Y provider"). If a repo has an active deferral, it lives in that repo's CLAUDE.md or a TODO filedo not re-flag it here from a general stance.
6767
- **Generic "consider adding tests"** without naming the specific behavior gap the new test would close.
6868
- **Style-only nits** in files the PR didn't change.
6969
- **Renaming for taste** unless it prevents a future conflict or bug.

0 commit comments

Comments
 (0)