You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: rate limited by coderabbit.ai -->\n\n> [!WARNING]\n> ## Rate limit exceeded\n> \n> `@kixelated` has exceeded the limit for the number of commits that can be reviewed per hour. Please wait **0 minutes and 29 seconds** before requesting another review.\n> \n> <details>\n> <summary>\u231b How to resolve this issue?</summary>\n> \n> After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR.\n> \n> We recommend that you space out your commits to avoid hitting the rate limit.\n> \n> </details>\n> \n> \n> <details>\n> <summary>\ud83d\udea6 How do rate limits work?</summary>\n> \n> CodeRabbit enforces hourly rate limits for each developer per organization.\n> \n> Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.\n> \n> Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.\n> \n> </details>\n> \n> <details>\n> <summary>\u2139\ufe0f Review info</summary>\n> \n> <details>\n> <summary>\u2699\ufe0f Run configuration</summary>\n> \n> **Configuration used**: Organization UI\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `e42accb7-16ae-477e-9486-11cf98b147dc`\n> \n> </details>\n> \n> <details>\n> <summary>\ud83d\udce5 Commits</summary>\n> \n> Reviewing files that changed from the base of the PR and between 9ca482c51c5965d254079b830a60ece75e014ee3 and 0afbd2ba1291e0c59afff8892c3e168b3b33559d.\n> \n> </details>\n> \n> <details>\n> <summary>\ud83d\udcd2 Files selected for processing (1)</summary>\n> \n> * `draft-lcurley-moq-probe.md`\n> \n> </details>\n> \n> </details>\n\n<!-- end of auto-generated comment: rate limited by coderabbit.ai -->\n\n<!-- walkthrough_start -->\n\n## Walkthrough\n\nThis change introduces a new draft specification document defining the MoQ Probe (PROBE) extension for MoQ Transport. The extension enables bidirectional communication between a subscriber and publisher for bandwidth probing and padding control. The document specifies setup negotiation via dedicated Setup Options, defines a new PROBE stream type, introduces PROBE_REQUEST messages containing target bitrates, and specifies PROBE_RESPONSE messages reporting measured bitrate and elapsed time. Additional sections address padding behavior, security considerations including rate-limiting and anti-flood measures, and IANA registrations for the new PROBE setup option and stream types.\n\n<!-- walkthrough_end -->\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n<details>\n<summary>\ud83d\udea5 Pre-merge checks | \u2705 3</summary>\n\n<details>\n<summary>\u2705 Passed checks (3 passed)</summary>\n\n| Check name | Status | Explanation |\n| :----------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | \u2705 Passed | The title accurately describes the main change: removing duplicate padding definitions and referencing moq-transport padding instead of duplicating them in the probe extension. |\n| Description check | \u2705 Passed | The description clearly relates to the changeset, detailing the removal of duplicate padding definitions and IANA registrations while adding references to moq-transport Section 7.7. |\n| Docstring Coverage | \u2705 Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n</details>\n\n<sub>\u270f\ufe0f Tip: You can configure your own custom pre-merge checks in the settings.</sub>\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>\u2728 Finishing Touches</summary>\n\n<details>\n<summary>\ud83e\uddea Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} --> Commit unit tests in branch `probe-extension`\n\n</details>\n<details>\n<summary>\u2728 Simplify code</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f120d606-b0e2-4b7d-8316-181794555b43\", \"radioGroupId\": \"simplify-output-choice-group-unknown_comment_id\"} --> Create PR with simplified code\n- [ ] <!-- {\"checkboxId\": \"9a4e3077-58f6-4eba-b7ee-62e936ea00ea\", \"radioGroupId\": \"simplify-output-choice-group-unknown_comment_id\"} --> Commit simplified code in branch `probe-extension`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- pr_review_plan_action_start -->\n\n<details>\n<summary>\ud83d\udcdd Coding Plan</summary>\n\n- [ ] <!-- {\"checkboxId\": \"6ad8a4e1-0b3a-4ea2-9b5b-d82c1f47d1f2\"} --> Generate coding plan for human review comments\n\n</details>\n\n<!-- pr_review_plan_action_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=moq-dev/drafts&utm_content=18)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>\u2764\ufe0f Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcbJAGaUZAwkkMz4AI5guFQYiNz4FLg8aLS08BhEKFi8giEkAB40sfD4WJAGAHKOApRcAIwAHJDlAKo2ADJcsLi43IgcAPQDROqw2AIaTMwDYZFKEgO0VH64iAPc2B4eA43NBi2ItZAA1vD5JB7UdHsAyvjYFMGQAjEMsFw5NWAFRYglWIAkwhgzlISRemDeXGY2jKBhuuGo2H6/G4ZD2AGEKCQrvRqFwAEwABnxADYwISAMxgOoAdmghLqHHxDQ4FIALAAtIw3RzQlz8PyMWCYUj9AxQCr4GjIXDCpKzMAAdyIMwiURicQSuDMdTZNIArOhUtduCk0hl7NFscxkJh6LRqGgiFQbZACJAlmgVtSGhpxZBfGEpMhaNhuB54AwrslUulMko/Ol1P9kAAKACKLQAkuiwF4pB4Y+bMnaPY7nWhmEW4wBKSB+CgsN2wEKfPKFMh/Up+qCB/DB5shACyAHl09BIAARcsumCyVGQLMAQQqS8gWJGiGi1H+9cbVdlrcbNUgP07u9TGHwisgwowtC89HSoTV29i8USNZ7Af8gQwwWQBU301RJIBuURxFKSAaQ0Gl6wSasLTYN5MCQV1ZUbbAiFge4kkPHhj3bX5/j9AxoGkJJw0wDh/QANUoeA/HkT0VmebB4A8WhkEVUZIAAA2hY4SD479fAkeASBvWVqHsCDdyxAIsX/aRQmoN4PWWXAfUgDBqgYjJSIAcTIZQaHoHjZUgdFLmwJQrMUEJU1RPhbA9aQGAoeBuEgjAv3MSx0RYZh1FCaRECdFSHCcFwjCgLMMGTNBCymYKkjNW1rBsEcACEAFFnngNIsTEf4kstLFK1PDtiigvwEIEO0eNoSyKPgaEfIAGiyBgPFsuN7DDD8kjqvhMxzawswqQyAGorCXSdJ0mwz+D4B0EQrKs/CSjwGoYY50HvI0ljClS0G4cNIx3Uo8za9RriYDJWqg1r2t3EbICXbK7DYNI0DciMpBcb8eQEQ5wmwdgFFYEKzWuTBFxXNcNyQbcfPgvh8NsHL8rWp1Z1wecSC6nrnEYiT6DYNAHCxWgwDUVGQkOaEMHEBhbQ8/BEGQB7onwLZKEQLrS1h+gqBoG7Uv6oh2IdZTvwAMXSMqUpCrEgxUjx8CjQtTVjC0EyTHzbUO/Dl1XMt1tnZGtzF/4uvSLdsVF38lIYfqgI1IbIFTBSvBKpC1WVVVImAoadT1fU63dNAJHwQqPTDCMox80j9GMcAoDIeh8EFNA8EIUhyDF+6gvYD4+EEEQSoHOQFCUKhVHULQdDTkwoDgVBUHhvOCGIEzi/oFKy/XNAbyivl5Frph65Uenm90MBDHT0wDBYrSPAYB4vFkMAFTbDRmFoGiACJT4MCwPqzPui5xAbovkHOhRFaQjCXVIMvIG8149LXHEhg2EoWnwkOfA6ZrCEW9ljPKdYzw1SwO9EBYDoCey1BoGALYqrEWehgFQXgMoOFBh5eANQMb4HXCQcGFFEKZDDG6Mhf0EQUFBAVBm/AsB/TUEVOSpQypQPyjba0XULKwEHDwcYEZEAtj4DkcSxYeAMUUJGTK2MAD6Nhco3CsCOCoNx8qU2piQNgLM0z02LgdegFwzqHHoOINgX5IAAGkSDyCmPEcgxjuq9SUDRKA4FcC0PIEQKU8AroYC4HwzB54oKBOCbfUMnkLS6OgC0KwkBxJ/T+koNIydrh+NoSOby/wADc9ZtC9SxHQnSJAgniGjFiBwHhVhZHQMo6AI50QjnaCo2iWZOlLmgL0io34InwgqswLg6ReahgAi0z+5VrRukJujZReVibOBcP1PhajcqZg0ROUsWz1GaO0bo0KXMIqIBKQIyq0JJ4hB6pza4CF6kkDBPIEgoxKDJESLIYZWU8rbN2TcaAXAeYwgyow5hpirglMJFkbJVxkBXmoV1LcHFCxYiGsgQ5GitE6NyiU5gmxxDhhCFiShW5kAOGctYo8JQK7kEQH81RRy8W6NBaUBEDtQpUweNcaFNBzGnkuH0a4tjGbpCeJcLc5DNSxBICU5yJRsmQDDGtFSwjyFD3vNcOohJCQ2kAMgEer9WukmZQCQSVhlmn6jUYU4kEgfHEUgKRMYZRkIqupSFryWFmKRP1RB1DQooQSogG0hKkRJCvEkAowQxUgh9QhB1lxBVjXRAoR6aKoI80bB4EpMc47Z0BmAXWxZgaiAeOoFxpQ/gzyNlwCMqVkBQW9bgLqxcJbJgyELQ6mBxBgD8JrRQPKDFMv9GbNcD1a2mRTFwa2qMUzLIiYcfx3AURowJguA5/z+FWkqpukg34lx7SvIqR8RAjGrFBTTdQSKpSHqMCOUGFrQnIklGIgQSc64kAHWgN2+tRCXFtjW9AFTJmNmmdcZ8spUBpD8IKVMtBf6XrAKUDwLi7yinsXAe5nL/7+HSCpHIBAmCFiZn2yMgsznhVIOjdqVHSwxNqWjCgmxpBdRGsFC0f1DgeD8GAMFhGLHVS7FgOIogybJ13MI6DGDA0NkrJJBIxxSIAG11qkHoO9LE4lJJcAALr+Q+o0mdIH3T4SUCTYDsQBRVSGk86RzqGCnhZsmF+/pJTkCMO0Qj3NMN0C4NNOoABONkAxyRGFymi9qJc7I6YkjefwI1OCQCHHQeAjgDCn2PrFRey9M6HUfj3Au/db7apS1QMevJnCT2rTPRumhtAL0MG3KGqUVGFUQCo+Lkk6AqK3M4JIacDCteC1GNkDR8QMH1HUabwWST6loPifUbJCQ0mCwIBoFJCRoBJISUQJADQkAZGyEgJAKTNfy219QHWuLdZILpxUfWs6Xda7wEgKi2BMI+28UQxwusDdAsNgA3gYZox8kC2GyprPadBAqsHYFYTmZlj5cC2h4Q4HUweQAh4gEcgNPLGgwKj0pGOibY+Pkhtm0Q4yBUBhFeKNAKA4I8PCK4JPgcAF8sfg+niQGws91AAHVGw0CsBQdwuAvAk/R5jinkj7icWh1rY4tgZdJTl+DtItAbDYAwJOLWoy4yIHRC2PaJPogQx5zj7XuuMCS68Kbv7FvWPk614VO3k53KeUKaUJ35uuCW7dzjiMGAhK0CzFzCGiBRkk9Ptb4+0rcD++OL4BpqwSeqex80UHzQ8849+3tCoim48O/uWb44x9rf5+PgN/xiAXdW+z3n4+BQqI4J8qXjB4gpchD/ZvYu6G3KICITUGUGDoTPhDaQOdhj+z9VDBdHJQaAHJhA6WBSf5/2ZA9pgEClEbUWgdjQFItnF9Jx3EAlsVZZNHlyJEuBGgq/N/B2EJQcfFTOEAUQZ/+fwfFVKETGlixHVzJ2rxbwSHgBGBZxT2LzYDjx72l2b252b1zz/2PkL2ODgJIDjy9xHx9zRkwN/3QLryREb2Dxrzb0uA73+C7xCCUHwK8kIK8GcCHyxBTRUnMwwWn2kFeS6iUC5VD0yHwjVn7DKkfnP0ukFVLQXwIwSiNiFQnXIU3AXRA0VAQC8COn6k31dk4LIV33fC1DAm4SwBghgmIJrzfxwK4GPk/2ZzjAsJbwAIwCAL5VAM13QMgOgKSlgJLxsIYKIV92J2QPALQJr0wOwNwK1htn6jp2UFIEcPB1IIb0D1d3APByoMwFCTj3fT8D1xKhAzqj1yfCwHwh4K0w4j0NPEtV6mjCpxiItCYHp1IDQRuFOHOgX2iJp0aP7HiPLz+yf3SJx3qT5jwFoJsJFzuh/mpwSSIGQHenwjyP/AUOCi5n6kPAPDIXCnEEQCYlESaL6ObHqRwk4kGJfxxysI/y/wcKGOPi8KVg8F8PgP8K6NmIb2QOx30wTyT1sDwMCM7xsLqDqC2mJDZFJAaD1T8D1FoAaBWzZAYDjRpApBIHxBpBUC9EpBJDqApDQF1BIH1AYAED8EJHhIaCWz8AYCRNoBJDRL8AaF22IMTyplwFsDLzj31BqAaD8GC2CwdAajqFoEJH1BpD8A5KBIpCjAaDJNoDqDQBIGCz8FoH1D8ApBJAaAEH1H1FxMm2CxCxIBJCxIaBpFoAEBhJJDQBpBJHxBy05yu3e0+0oFIBUUwK6xe1bgzhwAIBUVNCRA+zrz9MYSGzywMGByZK3CsDzmsSXFwDEgSzhyCnUECj11wFR0JFtJGw9OK29MjIDKuBUTdMXiAA== -->\n\n<!-- internal state end -->",
889
+
"createdAt": "2026-03-17T01:31:04Z",
890
+
"updatedAt": "2026-03-17T01:46:58Z"
891
+
}
892
+
],
893
+
"reviews": [
894
+
{
895
+
"id": "PRR_kwDOLz_x-M7r5avq",
896
+
"commit": {
897
+
"abbreviatedOid": "9ca482c"
898
+
},
899
+
"author": "coderabbitai",
900
+
"authorAssociation": "NONE",
901
+
"state": "COMMENTED",
902
+
"body": "**Actionable comments posted: 1**\n\n<details>\n<summary>\ud83e\uddf9 Nitpick comments (1)</summary><blockquote>\n\n<details>\n<summary>draft-lcurley-moq-probe.md (1)</summary><blockquote>\n\n`19-23`: **Reference management should follow repo\u2019s bibxml-include convention.**\n\nThis draft defines references in frontmatter, but I don\u2019t see explicit bibxml include usage. If your repo tooling requires include-based reference management for drafts, please align this section accordingly.\n\n\nAs per coding guidelines, \"Manage references via bibxml includes in draft documents\".\n\n<details>\n<summary>\ud83e\udd16 Prompt for AI Agents</summary>\n\n```\nVerify each finding against the current code and only fix it if needed.\n\nIn `@draft-lcurley-moq-probe.md` around lines 19 - 23, Replace the inline\nfrontmatter references with the repo's bibxml-include pattern: remove the\nexplicit \"moqt: I-D.ietf-moq-transport\" entry under the normative block and\ninstead add the appropriate bibxml include directive (e.g., an <biblioref>\ninclude or the repo-specific include tag) referencing I-D.ietf-moq-transport so\nreferences are managed via bibxml includes; ensure the informative block remains\nempty or uses includes as needed and that the unique symbol \"moqt:\nI-D.ietf-moq-transport\" is referenced only through the include tag used by the\nrepository tooling.\n```\n\n</details>\n\n</blockquote></details>\n\n</blockquote></details>\n\n<details>\n<summary>\ud83e\udd16 Prompt for all review comments with AI agents</summary>\n\n```\nVerify each finding against the current code and only fix it if needed.\n\nInline comments:\nIn `@draft-lcurley-moq-probe.md`:\n- Line 76: Replace the literal 0xPROBE_TODO with a proper RFC-style TBD\nplaceholder and make it consistent across all occurrences (the Option Key\ndeclaration \"Option Key (vi64) = 0xPROBE_TODO\" and the other mentions). Use a\nsingle TBD token (e.g., TBD1) for the first reserved value and a second token\n(e.g., TBD2) only if a distinct reserved value is required, and mirror that\nexact TBD identifier in the wire-format text and the IANA registry table entries\nso implementers see the same placeholder everywhere (update the Option Key line,\nthe wire-format field descriptions, and the IANA table entries such as those\nreferenced in the comment).\n\n---\n\nNitpick comments:\nIn `@draft-lcurley-moq-probe.md`:\n- Around line 19-23: Replace the inline frontmatter references with the repo's\nbibxml-include pattern: remove the explicit \"moqt: I-D.ietf-moq-transport\" entry\nunder the normative block and instead add the appropriate bibxml include\ndirective (e.g., an <biblioref> include or the repo-specific include tag)\nreferencing I-D.ietf-moq-transport so references are managed via bibxml\nincludes; ensure the informative block remains empty or uses includes as needed\nand that the unique symbol \"moqt: I-D.ietf-moq-transport\" is referenced only\nthrough the include tag used by the repository tooling.\n```\n\n</details>\n\n---\n\n<details>\n<summary>\u2139\ufe0f Review info</summary>\n\n<details>\n<summary>\u2699\ufe0f Run configuration</summary>\n\n**Configuration used**: Organization UI\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `f96aeed9-ba0c-443a-ab4a-0b9269978291`\n\n</details>\n\n<details>\n<summary>\ud83d\udce5 Commits</summary>\n\nReviewing files that changed from the base of the PR and between 59bdc77a6a5da3403ac0b9b4dff3b1490901151c and 9ca482c51c5965d254079b830a60ece75e014ee3.\n\n</details>\n\n<details>\n<summary>\ud83d\udcd2 Files selected for processing (1)</summary>\n\n* `draft-lcurley-moq-probe.md`\n\n</details>\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit for review status -->",
903
+
"createdAt": "2026-03-17T01:31:08Z",
904
+
"updatedAt": "2026-03-17T01:31:08Z",
905
+
"comments": [
906
+
{
907
+
"originalPosition": 76,
908
+
"body": "_\u26a0\ufe0f Potential issue_ | _\ud83d\udfe0 Major_\n\n**Replace `0xPROBE_TODO` with proper IANA TBD notation and keep it consistent across wire/registry text.**\n\nUsing `0xPROBE_TODO` in protocol fields is ambiguous for implementers and can cause interop drift. Please use RFC-style `TBD` placeholders (and, if needed, separate `TBD1`/`TBD2`) and mirror the same placeholders in the IANA tables and wire-format definitions.\n\n\n\n\nAlso applies to: 89-89, 178-178, 186-186\n\n<details>\n<summary>\ud83e\udd16 Prompt for AI Agents</summary>\n\n```\nVerify each finding against the current code and only fix it if needed.\n\nIn `@draft-lcurley-moq-probe.md` at line 76, Replace the literal 0xPROBE_TODO with\na proper RFC-style TBD placeholder and make it consistent across all occurrences\n(the Option Key declaration \"Option Key (vi64) = 0xPROBE_TODO\" and the other\nmentions). Use a single TBD token (e.g., TBD1) for the first reserved value and\na second token (e.g., TBD2) only if a distinct reserved value is required, and\nmirror that exact TBD identifier in the wire-format text and the IANA registry\ntable entries so implementers see the same placeholder everywhere (update the\nOption Key line, the wire-format field descriptions, and the IANA table entries\nsuch as those referenced in the comment).\n```\n\n</details>\n\n<!-- fingerprinting:phantom:triton:hawk -->\n\n<!-- This is an auto-generated comment by CodeRabbit -->\n\n\u2705 Addressed in commit 9a91ab0",
0 commit comments