Merge pull request #111 from morpho-org/refactor/constant-comments

Refactor constant comments

Author: QGarchery

certora/specs/wadRayMath.spec

@@ -215,7 +215,7 @@ rule wadToRaySafety(uint256 a) {
 rule wadToRayLiveness(uint256 a) {
     wadToRay@withrevert(a);
 
-    assert lastReverted <=> a * WADTORAY() > UINT_LIMIT();
+    assert lastReverted <=> a * WADTORAY() >= UINT_LIMIT();
 }
 
 /// wadWeightedAvg ///

src/math/CompoundMath.sol

@@ -7,8 +7,8 @@ pragma solidity ^0.8.0;
 /// @dev Library to perform Compound's multiplication and division in an efficient way.
 library CompoundMath {
     /* CONSTANTS */
-
     // Only direct number constants and references to such constants are supported by inline assembly.
+
     uint256 internal constant WAD = 1e18;
     uint256 internal constant MAX_UINT256 = 2 ** 256 - 1;
 

src/math/Math.sol

@@ -7,10 +7,12 @@ pragma solidity ^0.8.0;
 /// @dev Library to perform simple math manipulations.
 library Math {
     /* CONSTANTS */
-
     // Only direct number constants and references to such constants are supported by inline assembly.
+
     int256 internal constant MIN_INT256 = -2 ** 255;
 
+    /* INTERNAL */
+
     function abs(int256 x) internal pure returns (int256 y) {
         assembly {
             let mask := sar(255, x)

src/math/PercentageMath.sol

@@ -7,8 +7,8 @@ pragma solidity ^0.8.0;
 /// @notice Optimized version of Aave V3 math library PercentageMath to conduct percentage manipulations: https://github.com/aave/aave-v3-core/blob/master/contracts/protocol/libraries/math/PercentageMath.sol
 library PercentageMath {
     /* CONSTANTS */
-
     // Only direct number constants and references to such constants are supported by inline assembly.
+
     uint256 internal constant PERCENTAGE_FACTOR = 100_00;
     uint256 internal constant HALF_PERCENTAGE_FACTOR = 50_00;
     uint256 internal constant PERCENTAGE_FACTOR_MINUS_ONE = 100_00 - 1;

src/math/WadRayMath.sol

@@ -7,8 +7,8 @@ pragma solidity ^0.8.0;
 /// @notice Optimized version of Aave V3 math library WadRayMath to conduct wad and ray manipulations: https://github.com/aave/aave-v3-core/blob/master/contracts/protocol/libraries/math/WadRayMath.sol
 library WadRayMath {
     /* CONSTANTS */
-
     // Only direct number constants and references to such constants are supported by inline assembly.
+
     uint256 internal constant WAD = 1e18;
     uint256 internal constant HALF_WAD = 0.5e18;
     uint256 internal constant WAD_MINUS_ONE = 1e18 - 1;