Skip to content

Commit 9a5eaec

Browse files
committed
Fix Sanic compatibility issues.
1 parent 4dd365d commit 9a5eaec

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

tests/sanic/test_sanic.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,14 @@ def test_redis_check_error(dockerflow_redis, mocker, test_client, error, message
204204
assert response.json["details"]["check_redis_connected"]["messages"] == messages
205205

206206

207-
def assert_log_record(caplog, errno=0, level=logging.INFO, rid=None, t=int):
207+
def assert_log_record(caplog, errno=0, level=logging.INFO, rid=None, t=int, path="/"):
208208
records = [r for r in caplog.records if r.name == "request.summary"]
209209
assert len(records) == 1
210210
record = records.pop()
211211
assert record.agent == "dockerflow/tests"
212212
assert record.lang == "tlh"
213213
assert record.method == "GET"
214-
assert record.path == "/"
214+
assert record.path == path
215215
assert record.errno == errno
216216
assert record.levelno == level
217217
assert getattr(record, "rid", None) == rid
@@ -232,9 +232,15 @@ def test_request_summary(caplog, dockerflow, test_client):
232232
assert_log_record(caplog, rid=request.get("_id"))
233233

234234

235-
def test_request_summary_exception(caplog, dockerflow, test_client):
236-
request, _ = test_client.get(data="exception message", headers=headers)
237-
record = assert_log_record(caplog, 500, logging.ERROR, request.get("_id"))
235+
def test_request_summary_exception(app, caplog, dockerflow, test_client):
236+
@app.route("/exception")
237+
def exception_raiser(request):
238+
raise ValueError("exception message")
239+
240+
request, _ = test_client.get("/exception", headers=headers)
241+
record = assert_log_record(
242+
caplog, 500, logging.ERROR, request.get("_id"), path="/exception"
243+
)
238244
assert record.getMessage() == "exception message"
239245

240246

0 commit comments

Comments
 (0)