Skip to content

Commit c7eceff

Browse files
author
JT
committed
improve code readability
1 parent 109c6b1 commit c7eceff

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

bugbot/rules/not_landed.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,8 @@ def get_bz_userid(self, phids):
263263
return {}
264264

265265
def handler(user, data):
266-
data[str(user["id"])] = (user["name"], user["nick"])
266+
# data[str(user["id"])] = (user["name"], user["nick"])
267+
data[str(user["id"])] = user
267268

268269
data = {}
269270
BugzillaUser(
@@ -311,13 +312,13 @@ def get_bugs(self, date="today", bug_ids=[]):
311312
res = {}
312313

313314
reviewers_phid = set()
314-
nicknames = {}
315+
bug_assignee_map = {}
315316
for bugid, data in bugs_patch.items():
316317
reviewers_phid |= data["reviewers_phid"]
317318
assignee = bugs[bugid]["assigned_to"]
318319
if not assignee:
319320
assignee = max(data["author"], key=data["author"].get)
320-
nicknames[bugid] = assignee
321+
bug_assignee_map[bugid] = assignee
321322

322323
bz_reviewers = self.get_bz_userid(reviewers_phid)
323324
all_reviewers = set(bz_reviewers.keys())
@@ -329,7 +330,8 @@ def get_bugs(self, date="today", bug_ids=[]):
329330
nickname = d["nickname"]
330331

331332
if not assignee:
332-
assignee, nickname = bz_reviewers[nicknames[bugid]]
333+
assignee_id = bug_assignee_map[bugid]
334+
assignee, nickname = bz_reviewers[assignee_id]
333335

334336
if not assignee:
335337
continue

0 commit comments

Comments
 (0)