[Bug]: Opening editor toolbar falsely enables hidden highlights

[LoukasPap]

Attach (recommended) or Link to PDF file

Toggling off "Show all" in highlighter menu is set in false state when closing and re-opening the menu.

Web browser and its version

Firefox, Version 150.0.1 (64-bit)

Operating system and its version

Windows 11, Version 10.0.26100

PDF.js version

The one bundled with the Firefox version mentioned above

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

1. Highlight a text
2. Disable "Show all" in the Highlight menu
3. Close the Highlight menu
4. Open the Highlight menu
5. The highlights are appearing again but the "Show all" status is disabled

What is the expected behavior?

What went wrong?

Link to a viewer

No response

Additional context

Also, if highlights are off, opening the highlight menu enables all highlights. I am not sure if this behavior is correct or if it should keep the highlights off. In case this is wrong behavior, then the problem is transferred to "falsely enabling highlights" than "falsely disabled status".

[LoukasPap]

@timvandermeij Do we know which one is the false behavior here? The wrongly disabled status or the highlight popup enabling highlights when opened?

[LoukasPap]

Hi @timvandermeij! If it's ok, can you point me to a direction I should follow regarding the above? :)

[calixteman]

The wrong behavior is showing the hidden highlights when re-opened.