fix: run lint script and fix errors

Author: crisryantan

.eslintrc

@@ -24,6 +24,7 @@
         "no-prototype-builtins": "off",
         "no-empty": "off",
         "no-useless-escape": "off",
-        "no-unexpected-multiline": "off"
+        "no-unexpected-multiline": "off",
+        "no-unused-vars": ["error", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }]
     }
 }

package.json

@@ -8,7 +8,7 @@
   "repository": "https://github.com/mparticle-integrations/mparticle-javascript-integration-rokt",
   "scripts": {
     "build": "ENVIRONMENT=production rollup --config rollup.config.js",
-    "build:test": "ENVIRONMENT=production rollup --config rollup.test.config.js",
+    "build:test": "rollup --config rollup.test.config.js",
     "lint": "eslint src/ test/src/",
     "lint:fix": "eslint src/ test/src/ --fix",
     "watch": "ENVIRONMENT=production rollup --config rollup.config.js -w",

src/commerce-handler.js

@@ -2,7 +2,7 @@ function CommerceHandler(common) {
     this.common = common || {};
 }
 
-CommerceHandler.prototype.logCommerceEvent = function(event) {
+CommerceHandler.prototype.logCommerceEvent = function (_event) {
     /*
         Sample ecommerce event schema:
         {

src/common.js

@@ -2,6 +2,6 @@ function Common() {}
 
 Common.prototype.exampleMethod = function () {
     return 'I am an example';
-}
+};
 
-module.exports = Common;
+module.exports = Common;

src/event-handler.js

@@ -16,15 +16,15 @@ A non-ecommerce event has the following schema:
 function EventHandler(common) {
     this.common = common || {};
 }
-EventHandler.prototype.logEvent = function(event) {};
-EventHandler.prototype.logError = function(event) {
+EventHandler.prototype.logEvent = function (_event) {};
+EventHandler.prototype.logError = function (_event) {
     // The schema for a logError event is the same, but noteworthy differences are as follows:
     // {
     //     EventAttributes: {m: 'name of error passed into MP', s: "Error", t: 'stack trace in string form if applicable'},
     //     EventName: "Error"
     // }
 };
-EventHandler.prototype.logPageView = function(event) {
+EventHandler.prototype.logPageView = function (_event) {
     /* The schema for a logPagView event is the same, but noteworthy differences are as follows:
         {
             EventAttributes: {hostname: "www.google.com", title: 'Test Page'},  // These are event attributes only if no additional event attributes are explicitly provided to mParticle.logPageView(...)
@@ -33,4 +33,3 @@ EventHandler.prototype.logPageView = function(event) {
 };
 
 module.exports = EventHandler;
-

src/identity-handler.js

@@ -21,33 +21,32 @@ For more userIdentity types, see https://docs.mparticle.com/developers/sdk/web/i
 function IdentityHandler(common) {
     this.common = common || {};
 }
-IdentityHandler.prototype.onUserIdentified = function(mParticleUser) {};
-IdentityHandler.prototype.onIdentifyComplete = function(
-    mParticleUser,
-    identityApiRequest
+IdentityHandler.prototype.onUserIdentified = function (_mParticleUser) {};
+IdentityHandler.prototype.onIdentifyComplete = function (
+    _mParticleUser,
+    _identityApiRequest
 ) {};
-IdentityHandler.prototype.onLoginComplete = function(
-    mParticleUser,
-    identityApiRequest
+IdentityHandler.prototype.onLoginComplete = function (
+    _mParticleUser,
+    _identityApiRequest
 ) {};
-IdentityHandler.prototype.onLogoutComplete = function(
-    mParticleUser,
-    identityApiRequest
+IdentityHandler.prototype.onLogoutComplete = function (
+    _mParticleUser,
+    _identityApiRequest
 ) {};
-IdentityHandler.prototype.onModifyComplete = function(
-    mParticleUser,
-    identityApiRequest
+IdentityHandler.prototype.onModifyComplete = function (
+    _mParticleUser,
+    _identityApiRequest
 ) {};
 
 /*  In previous versions of the mParticle web SDK, setting user identities on
     kits is only reachable via the onSetUserIdentity method below. We recommend
     filling out `onSetUserIdentity` for maximum compatibility
 */
-IdentityHandler.prototype.onSetUserIdentity = function(
-    forwarderSettings,
-    id,
-    type
+IdentityHandler.prototype.onSetUserIdentity = function (
+    _forwarderSettings,
+    _id,
+    _type
 ) {};
 
 module.exports = IdentityHandler;
-

src/initialization.js

@@ -25,7 +25,7 @@ var initialization = {
         _clientId
     ) {
         if (!testMode) {
-            if (!window.Rokt && !window.Rokt?.currentLauncher) {
+            if (!window.Rokt || !(window.Rokt && window.Rokt.currentLauncher)) {
                 var target = document.head || document.body;
                 var script = document.createElement('script');
                 script.type = 'text/javascript';
@@ -39,8 +39,8 @@ var initialization = {
                     // Once the script loads, ensure the Rokt object is available
                     if (
                         window.Rokt &&
-                        typeof window.Rokt?.createLauncher === 'function'
-                        && window.Rokt?.currentLauncher === undefined
+                        typeof window.Rokt.createLauncher === 'function' &&
+                        window.Rokt.currentLauncher === undefined
                     ) {
                         window.Rokt.createLauncher({
                             accountId: forwarderSettings.accountId,

src/session-handler.js

@@ -1,10 +1,6 @@
 var sessionHandler = {
-    onSessionStart: function(event) {
-
-    },
-    onSessionEnd: function(event) {
-
-    }
+    onSessionStart: function (_event) {},
+    onSessionEnd: function (_event) {},
 };
 
 module.exports = sessionHandler;

src/user-attribute-handler.js

@@ -10,20 +10,19 @@ For any additional methods, see http://docs.mparticle.com/developers/sdk/javascr
 function UserAttributeHandler(common) {
     this.common = common || {};
 }
-UserAttributeHandler.prototype.onRemoveUserAttribute = function(
-    key,
-    mParticleUser
+UserAttributeHandler.prototype.onRemoveUserAttribute = function (
+    _key,
+    _mParticleUser
 ) {};
-UserAttributeHandler.prototype.onSetUserAttribute = function(
-    key,
-    value,
-    mParticleUser
+UserAttributeHandler.prototype.onSetUserAttribute = function (
+    _key,
+    _value,
+    _mParticleUser
 ) {};
-UserAttributeHandler.prototype.onConsentStateUpdated = function(
-    oldState,
-    newState,
-    mParticleUser
+UserAttributeHandler.prototype.onConsentStateUpdated = function (
+    _oldState,
+    _newState,
+    _mParticleUser
 ) {};
 
 module.exports = UserAttributeHandler;
-