Skip to content

Commit 05fa05f

Browse files
NAOR YUVALclaude
authored andcommitted
fix: review feedback on vehicleId→actorId rename
- Update stale example values: "veh-456"/"vehicle-456" → "actor-001" - Rename "Vehicle Wallet Roles" heading → "Actor Roles" in sdk.md - Fix scripts to import via public SDK alias (createSignedBudgetAuthorization) instead of internal dist/protocol/sba.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 5e56ec1 commit 05fa05f

6 files changed

Lines changed: 7 additions & 7 deletions

File tree

docs/implementation/sdk.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const grant = createPolicyGrant({
4646
const sba = createSignedBudgetAuthorization({
4747
grantId: grant.grantId,
4848
sessionId: "sess-123",
49-
actorId: "veh-456",
49+
actorId: "actor-001",
5050
policyHash: "a1b2c3",
5151
currency: "USD",
5252
maxAmountMinor: "3000",
@@ -93,7 +93,7 @@ const result = verifySettlement({
9393
// result.valid === true
9494
```
9595

96-
## Vehicle Wallet Roles
96+
## Actor Roles
9797

9898
In an autonomous deployment, the wallet plays both roles in this lifecycle:
9999

docs/reference/sdk.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ import {
5656
const budgetAuth = createBudgetAuthorization({
5757
grantId: grant.grantId, // from createPolicyGrant
5858
sessionId: "sess-123",
59-
actorId: "veh-456",
59+
actorId: "actor-001",
6060
policyHash: "a1b2c3",
6161
currency: "USD",
6262
maxAmountMinor: "3000",

docs/reference/service-api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Issue a signed budget authorization from a policy grant.
2222
const sba = issueBudget({
2323
policyGrant,
2424
sessionId: "session-123",
25-
actorId: "vehicle-456",
25+
actorId: "actor-001",
2626
maxAmountMinor: "3000",
2727
destinationAllowlist: ["rParking", "rCharging"],
2828
});

scripts/demo-verify.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ process.env.MPCP_SPA_SIGNING_PUBLIC_KEY_PEM = spaKeys.publicKey
3232
.toString();
3333
process.env.MPCP_SPA_SIGNING_KEY_ID = "mpcp-spa-signing-key-1";
3434

35-
const { createSignedSessionBudgetAuthorization } = await import("../dist/protocol/sba.js");
35+
const { createSignedBudgetAuthorization: createSignedSessionBudgetAuthorization } = await import("../dist/sdk/index.js");
3636
const { createSignedPaymentAuthorization } = await import("../dist/protocol/spa.js");
3737
const { runVerify } = await import("../dist/cli/verify.js");
3838

scripts/gen-fixture.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { dirname, join } from "node:path";
1010
const __dirname = dirname(fileURLToPath(import.meta.url));
1111

1212
// Load built modules (run npm run build first)
13-
const { createSignedSessionBudgetAuthorization } = await import("../dist/protocol/sba.js");
13+
const { createSignedBudgetAuthorization: createSignedSessionBudgetAuthorization } = await import("../dist/sdk/index.js");
1414
const { createSignedPaymentAuthorization } = await import("../dist/protocol/spa.js");
1515

1616
const sbaKeys = crypto.generateKeyPairSync("ed25519");

scripts/gen-vectors.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { dirname, join } from "node:path";
1010
const __dirname = dirname(fileURLToPath(import.meta.url));
1111
const VECTORS_DIR = join(__dirname, "..", "test", "vectors");
1212

13-
const { createSignedSessionBudgetAuthorization } = await import("../dist/protocol/sba.js");
13+
const { createSignedBudgetAuthorization: createSignedSessionBudgetAuthorization } = await import("../dist/sdk/index.js");
1414
const { createSignedPaymentAuthorization } = await import("../dist/protocol/spa.js");
1515
const { createSettlementIntent } = await import("../dist/sdk/createSettlementIntent.js");
1616

0 commit comments

Comments
 (0)