local scope

Author: dmcmanam

libs/commons-codec-1.5.jar

@@ -21,8 +21,6 @@ public class GetPickListValues {
     private static Log log = LogFactory.getLog(GetPickListValues.class);
     private final ConnectionPoolLIMS conn;
 
-    private final GetPickList task = new GetPickList();
-
     public GetPickListValues(ConnectionPoolLIMS conn){
         this.conn = conn;
     }
@@ -35,7 +33,8 @@ public List<String> getContent(@RequestParam(value = "list", defaultValue = "Cou
             values.add("FAILURE: list is not using a valid format");
             return values;
         }
-        task.init(list);
+        GetPickList task = new GetPickList();
+        task.setPicklist(list);
         log.info("Starting /getPickListValues query for " + list);
         Future<Object> result = conn.submitTask(task);
         try {

libs/commons-dbcp2-2.0.1.jar

@@ -23,7 +23,6 @@
 public class GetRecentDeliveries {
     private static Log log = LogFactory.getLog(GetRecentDeliveries.class);
     private final ConnectionPoolLIMS conn;
-    private final GetDelivered task = new GetDelivered();
 
     public GetRecentDeliveries(ConnectionPoolLIMS conn) {
         this.conn = conn;
@@ -34,8 +33,8 @@ public List<RequestSummary> getContent(@RequestParam(value = "time", defaultValu
                                            @RequestParam(value = "units", defaultValue = "NULL") String units,
                                            @RequestParam(value = "investigator", defaultValue = "NULL") String investigator,
                                            HttpServletRequest request) {
-        log.info("/getRecentDeliveries client IP:" + request.getRemoteAddr());
-        log.info("Starting /getRecentDeliveries?time=" + time + "&units="+units);
+        log.info("Starting /getRecentDeliveries?time=" + time + "&units=" + units + " client IP:" + request.getRemoteAddr());
+        GetDelivered task = new GetDelivered();
 
         if (!time.equals("NULL") && !investigator.equals("NULL")) {
             task.init(investigator, Integer.parseInt(time), units);

libs/commons-lang3-3.1.jar

@@ -16,7 +16,7 @@
 public class GetPickList extends LimsTask {
     private String picklist;
 
-    public void init(String picklist) {
+    public void setPicklist(String picklist) {
         this.picklist = picklist;
     }