Skip to content

Commit 7006afb

Browse files
msmdevmichalk8
andauthored
Improve GPCCA.optimize(): Change complex conjugate splitting handling etc (#13)
* Skip instead of raise in GPCCA.optimize when splitting eigenvalues, if more then one cluster number was supplied. * Add missing properties. Improve property names, add missing attributes, sort attributes/properties alphabetically, fix docstrings of GPCCA. * Warn/raise indicating splitting of complex conjugated eigenvalues instead of only conjugated eigenvalues. * Add example notebook adapted to changed properties and complex conjugate splitting handling. * get_sectionsf -> get_sections in _checks. * Improve grammar and fix typos/formulas in utils/_docs.py. * Set 'fail_on_warning: false' in .readthedocs.yml. * Replace metastable by macrostate. * Always show UserWarning. * Change data type of p from np.complex64 to np.complex128. * Add reference values for tests checking skipping because of eigenvalue splitting. * Don't raise, if m=n, but exclude from search for optimal cluster number. * Add and modify tests to check for correct splitting behavior and related warnings. * Fix linting * Ensure float64 * Add dtype tests * Fix .pre-commit-config.yml * Remove from example_matrix_mu=0 in tests * [ci skip] Add environment.yml for binder Co-authored-by: Michal Klein <michal.klein@protonmail.com>
1 parent 073cffb commit 7006afb

14 files changed

Lines changed: 1102 additions & 247 deletions

.pre-commit-config.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,8 @@ repos:
7272
- id: script-must-have-extension
7373
name: Check executable files use .sh extension
7474
types: [shell, executable]
75-
- id: shellcheck
7675
- repo: https://github.com/myint/rstcheck
77-
rev: master
76+
rev: 3f92957478422df87bd730abde66f089cc1ee19b
7877
hooks:
7978
- id: rstcheck
8079
- repo: https://github.com/asottile/blacken-docs
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Acknowledgements
2-
================
1+
Acknowledgments
2+
===============
33
We thank `Marcus Weber`_ and the Computational Molecular Design (`CMD`_) group at the Zuse Institute Berlin (`ZIB`_)
44
for the longstanding and productive collaboration in the field of Markov modeling of non-reversible molecular dynamics.
55
M. Weber, together with K. Fackeldey, had the original idea to employ Schur vectors instead of eigenvectors in the

docs/source/binder/requirements.txt

Lines changed: 0 additions & 3 deletions
This file was deleted.

docs/source/example.ipynb

Lines changed: 504 additions & 59 deletions
Large diffs are not rendered by default.

docs/source/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
installation
1212
api
1313
example
14-
acknowledgements
14+
acknowledgments
1515
references
1616

1717
.. |br| raw:: html

docs/source/spelling_wordlist.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
scipy
2+
docstring
23
conda
34
pygpcca
45
pyGPCCA
@@ -22,3 +23,5 @@ Universitaet
2223
macOS
2324
Fackeldey
2425
Röblitz
26+
Sikorski
27+
Zuse

environment.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
name: pygpcca
2+
3+
dependencies:
4+
- matplotlib
5+
- pip:
6+
- git+https://github.com/msmdev/pygpcca

0 commit comments

Comments
 (0)