Skip to content

Commit d756504

Browse files
committed
Merge pull request #21 from tavaresb/master
Record creation speed up, no need to fetch all attributes on each save
2 parents 27c2121 + 7d3016c commit d756504

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

eav/managers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def create(self, **kwargs):
161161
if not config_cls or config_cls.manager_only:
162162
return super(EntityManager, self).create(**kwargs)
163163

164-
attributes = config_cls.get_attributes()
164+
#attributes = config_cls.get_attributes()
165165
prefix = '%s__' % config_cls.eav_attr
166166

167167
new_kwargs = {}

eav/models.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,17 @@ class EnumValue(models.Model):
5757
5858
For example:
5959
60-
>>> yes = EnumValue.objects.create(value='yes')
61-
>>> no = EnumValue.objects.create(value='no')
62-
>>> unkown = EnumValue.objects.create(value='unkown')
60+
>>> yes = EnumValue.objects.create(value='Yes') # doctest: SKIP
61+
>>> no = EnumValue.objects.create(value='No')
62+
>>> unkown = EnumValue.objects.create(value='Unkown')
6363
6464
>>> ynu = EnumGroup.objects.create(name='Yes / No / Unkown')
6565
>>> ynu.enums.add(yes, no, unkown)
6666
67-
>>> Atrribute.objects.create(name='Has Fever?',
67+
>>> Attribute.objects.create(name='Has Fever?',
6868
... datatype=Attribute.TYPE_ENUM,
6969
... enum_group=ynu)
70+
<Attribute: Has the fever? (Multiple Choice)>
7071
7172
.. note::
7273
The same *EnumValue* objects should be reused within multiple
@@ -141,7 +142,7 @@ class Attribute(models.Model):
141142
>>> unkown = EnumValue.objects.create(value='unkown')
142143
>>> ynu = EnumGroup.objects.create(name='Yes / No / Unkown')
143144
>>> ynu.enums.add(yes, no, unkown)
144-
>>> Atrribute.objects.create(name='Has Fever?',
145+
>>> Attribute.objects.create(name='Has Fever?',
145146
... datatype=Attribute.TYPE_ENUM,
146147
... enum_group=ynu)
147148
<Attribute: Has Fever? (Multiple Choice)>
@@ -533,7 +534,7 @@ def __iter__(self):
533534
534535
This would allow you to do:
535536
536-
>>> for i in m.eav: print i
537+
>>> for i in m.eav: print i # doctest:SKIP
537538
'''
538539
return iter(self.get_values())
539540

0 commit comments

Comments
 (0)