fix: Clean up temporary files on write failure

Author: erral

src/mxdev/uv.py

@@ -59,16 +59,21 @@ def write(self, state: State) -> None:
         logger.info("[%s] Updating pyproject.toml...", self.namespace)
         self._update_pyproject(doc, state)
 
+        tmp = None
         try:
             with tempfile.NamedTemporaryFile(
                 mode="w", dir=pyproject_path.parent, suffix=".tmp", delete=False, encoding="utf-8"
             ) as f:
                 tomlkit.dump(doc, f)
                 tmp = f.name
             os.replace(tmp, str(pyproject_path))
+            tmp = None  # success, don't clean up
             logger.info("[%s] Successfully updated pyproject.toml", self.namespace)
         except OSError as e:
             logger.error("[%s] Failed to write pyproject.toml: %s", self.namespace, e)
+        finally:
+            if tmp and os.path.exists(tmp):
+                os.unlink(tmp)
 
     def _update_pyproject(self, doc: "tomlkit.TOMLDocument", state: State) -> None:
         """Modify the pyproject.toml document based on mxdev state."""

tests/test_uv.py

@@ -280,6 +280,9 @@ def test_hook_handles_oserror_on_write(mocker, tmp_path, monkeypatch):
 
     mock_logger.error.assert_called_with("[%s] Failed to write pyproject.toml: %s", "uv", mocker.ANY)
 
+    # Ensure no .tmp files are left behind
+    assert len(list(tmp_path.glob("*.tmp"))) == 0
+
 
 def test_hook_raises_runtime_error_if_tomlkit_missing(mocker, tmp_path, monkeypatch):
     monkeypatch.chdir(tmp_path)