release 1.7.1

Author: mylee04

README.md

@@ -13,19 +13,19 @@ Desktop notifications for AI coding tools - get alerts when tasks complete or in
   <img src="assets/multi-tools-support-02.png" width="48%" alt="All tools enabled"/>
 </p>
 
-[![Version](https://img.shields.io/badge/version-1.7.0-blue.svg)](https://github.com/mylee04/code-notify/releases)
+[![Version](https://img.shields.io/badge/version-1.7.1-blue.svg)](https://github.com/mylee04/code-notify/releases)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 [![macOS](https://img.shields.io/badge/macOS-supported-green.svg)](https://www.apple.com/macos)
 [![Linux](https://img.shields.io/badge/Linux-supported-green.svg)](https://www.linux.org/)
 [![Windows](https://img.shields.io/badge/Windows-supported-green.svg)](https://www.microsoft.com/windows)
 
 ---
 
-## What's New in v1.7.0
+## What's New in v1.7.1
 
-- **New macOS click-through commands**: use `cn click-through` to choose which app opens when you click a notification
-- **Embedded terminal support is much better**: IDE terminals such as PhpStorm can now map their runtime terminal key to the app bundle that should be activated
-- **Reviewer edge cases are covered**: click-through lookup now handles empty `TERM_PROGRAM` cases and search-based adds now prefer the live runtime terminal key
+- **Generated notification state files now live under `notifications/state`**: root-level `~/.claude/notifications` stays cleaner because internal rate-limit files no longer pile up beside user-facing settings
+- **Supported upgrades keep working during the move**: legacy root-level `last_notification_*` and `last_stop_notification` files are still read as fallback and are cleaned up on fresh writes
+- **Windows and Unix runtimes stay aligned**: both runtimes now use the same state-folder layout, and regression tests cover the new path behavior
 
 ---
 
@@ -212,6 +212,10 @@ cn test
 cn update     # Runs: npm install -g code-notify@latest
 ```
 
+**Too many `last_notification_*` files in `~/.claude/notifications`?**
+
+As of `v1.7.1`, generated rate-limit state files are stored under `~/.claude/notifications/state/` instead of cluttering the root notifications folder.
+
 ## Project Structure
 
 ```

bin/code-notify

@@ -6,7 +6,7 @@
 set -e
 
 # Version
-VERSION="1.7.0"
+VERSION="1.7.1"
 
 # Determine the directory where the script is located (resolve symlinks)
 SCRIPT_PATH="${BASH_SOURCE[0]}"

lib/code-notify/core/notifier.sh

@@ -133,7 +133,8 @@ get_tool_display_name() {
 TOOL_DISPLAY=$(get_tool_display_name "$TOOL_NAME")
 
 # Rate limiting for stop notifications (prevents spam from parallel sub-agents)
-RATE_LIMIT_DIR="$HOME/.claude/notifications"
+NOTIFICATIONS_DIR="$HOME/.claude/notifications"
+RATE_LIMIT_DIR="$NOTIFICATIONS_DIR/state"
 STOP_RATE_LIMIT_SECONDS="${CODE_NOTIFY_STOP_RATE_LIMIT_SECONDS:-10}"
 NOTIFICATION_RATE_LIMIT_SECONDS="${CODE_NOTIFY_NOTIFICATION_RATE_LIMIT_SECONDS:-180}"
 
@@ -147,6 +148,12 @@ get_rate_limit_file() {
     printf '%s/%s\n' "$RATE_LIMIT_DIR" "$key"
 }
 
+get_legacy_rate_limit_file() {
+    local key
+    key=$(sanitize_rate_limit_key "$1")
+    printf '%s/%s\n' "$NOTIFICATIONS_DIR" "$key"
+}
+
 get_notification_subtype() {
     if [[ "$HOOK_DATA" == *"idle_prompt"* ]]; then
         printf '%s\n' "idle_prompt"
@@ -180,8 +187,13 @@ get_notification_rate_limit_key() {
 is_rate_limited() {
     local rate_limit_key="$1"
     local rate_limit_seconds="$2"
-    local lock_file
+    local lock_file legacy_lock_file
     lock_file=$(get_rate_limit_file "$rate_limit_key")
+    legacy_lock_file=$(get_legacy_rate_limit_file "$rate_limit_key")
+
+    if [[ ! -f "$lock_file" ]] && [[ -f "$legacy_lock_file" ]]; then
+        lock_file="$legacy_lock_file"
+    fi
 
     if [[ ! -f "$lock_file" ]]; then
         return 1  # No previous notification, not rate limited
@@ -202,10 +214,14 @@ is_rate_limited() {
 
 update_rate_limit() {
     local rate_limit_key="$1"
-    local lock_file
+    local lock_file legacy_lock_file
     lock_file=$(get_rate_limit_file "$rate_limit_key")
+    legacy_lock_file=$(get_legacy_rate_limit_file "$rate_limit_key")
     mkdir -p "$RATE_LIMIT_DIR"
     date +%s > "$lock_file"
+    if [[ "$legacy_lock_file" != "$lock_file" ]]; then
+        rm -f "$legacy_lock_file"
+    fi
 }
 
 is_project_scoped_notification() {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "code-notify",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "description": "Desktop notifications for Claude Code, OpenAI Codex, and Gemini CLI",
   "license": "MIT",
   "homepage": "https://github.com/mylee04/code-notify#readme",

scripts/install-windows.ps1

@@ -20,7 +20,7 @@ param(
 $ErrorActionPreference = "Stop"
 
 # Version
-$VERSION = "1.7.0"
+$VERSION = "1.7.1"
 
 # Colors and formatting
 function Write-Success { param([string]$Message) Write-Host "[OK] $Message" -ForegroundColor Green }
@@ -33,6 +33,7 @@ function Write-Header { param([string]$Message) Write-Host "`n$Message" -Foregro
 $ClaudeHome = "$env:USERPROFILE\.claude"
 $InstallDir = "$env:USERPROFILE\.code-notify"
 $NotificationsDir = "$ClaudeHome\notifications"
+$NotificationStateDir = "$NotificationsDir\state"
 $LogsDir = "$ClaudeHome\logs"
 
 function Show-Banner {
@@ -93,7 +94,7 @@ function Install-ClaudeNotify {
     Write-Header "Installing Code-Notify..."
 
     # Create directories
-    $directories = @($InstallDir, "$InstallDir\bin", "$InstallDir\lib", $NotificationsDir, $LogsDir)
+    $directories = @($InstallDir, "$InstallDir\bin", "$InstallDir\lib", $NotificationsDir, $NotificationStateDir, $LogsDir)
     foreach ($dir in $directories) {
         if (-not (Test-Path $dir)) {
             New-Item -ItemType Directory -Path $dir -Force | Out-Null
@@ -106,7 +107,7 @@ function Install-ClaudeNotify {
 # Code-Notify PowerShell Module
 # https://github.com/mylee04/code-notify
 
-$script:VERSION = "1.7.0"
+$script:VERSION = "1.7.1"
 $script:ClaudeHome = if ($env:CLAUDE_HOME) { $env:CLAUDE_HOME } else { "$env:USERPROFILE\.claude" }
 $script:DefaultSettingsFile = "$script:ClaudeHome\settings.json"
 $script:AlternateSettingsFile = "$env:USERPROFILE\.config\.claude\settings.json"
@@ -1531,7 +1532,7 @@ function Get-ToolDisplayName {
 
 $ToolDisplay = Get-ToolDisplayName $ToolName
 
-$NotificationStateDir = "$ClaudeHome\notifications"
+$NotificationStateDir = "$ClaudeHome\notifications\state"
 
 try {
     $StopRateLimitSeconds = [int]($env:CODE_NOTIFY_STOP_RATE_LIMIT_SECONDS)
@@ -1597,6 +1598,13 @@ function Get-RateLimitPath {
     return Join-Path $NotificationStateDir $safeKey
 }
 
+function Get-LegacyRateLimitPath {
+    param([string]$Key)
+
+    $safeKey = ($Key -replace '[^A-Za-z0-9._-]', '_')
+    return Join-Path "$ClaudeHome\notifications" $safeKey
+}
+
 function Test-RateLimited {
     param(
         [string]$Key,
@@ -1608,6 +1616,13 @@ function Test-RateLimited {
     }
 
     $path = Get-RateLimitPath $Key
+    if (-not (Test-Path $path)) {
+        $legacyPath = Get-LegacyRateLimitPath $Key
+        if (Test-Path $legacyPath) {
+            $path = $legacyPath
+        }
+    }
+
     if (-not (Test-Path $path)) {
         return $false
     }
@@ -1630,7 +1645,13 @@ function Update-RateLimit {
     }
 
     $currentTime = [DateTimeOffset]::UtcNow.ToUnixTimeSeconds()
-    $currentTime | Set-Content (Get-RateLimitPath $Key) -Encoding ASCII
+    $path = Get-RateLimitPath $Key
+    $currentTime | Set-Content $path -Encoding ASCII
+
+    $legacyPath = Get-LegacyRateLimitPath $Key
+    if ($legacyPath -ne $path -and (Test-Path $legacyPath)) {
+        Remove-Item $legacyPath -Force -ErrorAction SilentlyContinue
+    }
 }
 
 # Function to check if notification should be suppressed

scripts/run_tests.sh

@@ -198,6 +198,22 @@ else
     test_fail "click-through commands failed"
 fi
 
+# Test 20: rate-limit state files live under notifications/state with legacy fallback
+test_start "notification state dir"
+if bash tests/test-notification-state-dir.sh >/dev/null 2>&1; then
+    test_pass
+else
+    test_fail "notification state dir failed"
+fi
+
+# Test 21: Windows notifier keeps rate-limit state under notifications/state
+test_start "windows rate-limit state"
+if bash tests/test-windows-rate-limit-state.sh >/dev/null 2>&1; then
+    test_pass
+else
+    test_fail "windows rate-limit state failed"
+fi
+
 # Summary
 echo ""
 echo "Test Summary:"

tests/test-notification-state-dir.sh

@@ -0,0 +1,108 @@
+#!/bin/bash
+
+set -e
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+NOTIFIER="$SCRIPT_DIR/../lib/code-notify/core/notifier.sh"
+
+pass() { echo "PASS: $1"; }
+fail() { echo "FAIL: $1"; exit 1; }
+
+wait_for_lines() {
+    local file="$1"
+    local expected_lines="$2"
+
+    for _ in $(seq 1 40); do
+        if [[ -f "$file" ]] && [[ $(wc -l < "$file") -ge "$expected_lines" ]]; then
+            return 0
+        fi
+        sleep 0.05
+    done
+
+    return 1
+}
+
+run_notifier() {
+    local fake_path="$1"
+    local subtype="$2"
+
+    printf '{"type":"%s"}\n' "$subtype" | \
+        PATH="$fake_path" \
+        CODE_NOTIFY_NOTIFICATION_RATE_LIMIT_SECONDS=180 \
+        bash "$NOTIFIER" notification claude test-project
+}
+
+test_dir="$(mktemp -d)"
+trap 'rm -rf "$test_dir"' EXIT
+
+export HOME="$test_dir/home"
+fake_bin="$test_dir/bin"
+log_dir="$test_dir/log"
+sound_file="$test_dir/custom.aiff"
+mkdir -p "$HOME/.claude/notifications" "$HOME/.claude/logs" "$fake_bin" "$log_dir"
+
+touch "$sound_file"
+: > "$HOME/.claude/notifications/sound-enabled"
+printf '%s\n' "$sound_file" > "$HOME/.claude/notifications/sound-custom"
+
+case "$(uname -s)" in
+    Darwin)
+        notification_log="$log_dir/terminal-notifier.log"
+        sound_log="$log_dir/afplay.log"
+        cat > "$fake_bin/terminal-notifier" <<EOF
+#!/bin/bash
+printf '%s\n' "\$*" >> "$notification_log"
+EOF
+        cat > "$fake_bin/afplay" <<EOF
+#!/bin/bash
+printf '%s\n' "\$*" >> "$sound_log"
+EOF
+        ;;
+    Linux)
+        notification_log="$log_dir/notify-send.log"
+        sound_log="$log_dir/paplay.log"
+        cat > "$fake_bin/notify-send" <<EOF
+#!/bin/bash
+printf '%s\n' "\$*" >> "$notification_log"
+EOF
+        cat > "$fake_bin/paplay" <<EOF
+#!/bin/bash
+printf '%s\n' "\$*" >> "$sound_log"
+EOF
+        ;;
+    *)
+        echo "SKIP: unsupported OS for notification state-dir test"
+        exit 0
+        ;;
+esac
+
+chmod +x "$fake_bin"/*
+
+fake_path="$fake_bin:/usr/bin:/bin:/usr/sbin:/sbin"
+state_file="$HOME/.claude/notifications/state/last_notification_claude_test-project_idle_prompt"
+legacy_file="$HOME/.claude/notifications/last_notification_claude_test-project_idle_prompt"
+
+run_notifier "$fake_path" "idle_prompt"
+
+wait_for_lines "$notification_log" 1 || fail "expected a notification delivery"
+[[ -f "$state_file" ]] || fail "rate-limit state file should be written under notifications/state"
+[[ ! -f "$legacy_file" ]] || fail "new notifications should not write legacy root-level rate-limit files"
+
+rm -f "$state_file"
+date +%s > "$legacy_file"
+lines_before=$(wc -l < "$notification_log")
+
+run_notifier "$fake_path" "idle_prompt"
+
+sleep 0.1
+lines_after=$(wc -l < "$notification_log")
+[[ "$lines_before" -eq "$lines_after" ]] || fail "legacy root-level rate-limit files should still suppress duplicates during upgrade"
+
+printf '%s\n' "0" > "$legacy_file"
+run_notifier "$fake_path" "idle_prompt"
+
+wait_for_lines "$notification_log" 2 || fail "expected a notification after legacy state aged out"
+[[ -f "$state_file" ]] || fail "fresh writes should recreate the state file under notifications/state"
+[[ ! -f "$legacy_file" ]] || fail "fresh writes should clean up legacy root-level rate-limit files"
+
+pass "notification state files move under notifications/state without breaking legacy fallback"

tests/test-windows-rate-limit-state.sh

@@ -0,0 +1,57 @@
+#!/bin/bash
+
+set -e
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+WINDOWS_INSTALLER="$SCRIPT_DIR/../scripts/install-windows.ps1"
+
+pass() { echo "PASS: $1"; }
+fail() { echo "FAIL: $1"; exit 1; }
+
+if ! grep -qF '$NotificationStateDir = "$NotificationsDir\state"' "$WINDOWS_INSTALLER"; then
+    fail "installer should create a dedicated notifications state directory"
+fi
+
+if ! grep -qF '$NotificationStateDir = "$ClaudeHome\notifications\state"' "$WINDOWS_INSTALLER"; then
+    fail "generated Windows notifier should store rate-limit files under notifications\\state"
+fi
+
+if ! grep -qF 'function Get-LegacyRateLimitPath' "$WINDOWS_INSTALLER"; then
+    fail "legacy rate-limit fallback helper is missing from the Windows notifier"
+fi
+
+if ! grep -qF 'Join-Path "$ClaudeHome\notifications" $safeKey' "$WINDOWS_INSTALLER"; then
+    fail "Windows legacy rate-limit fallback path is missing"
+fi
+
+if command -v pwsh >/dev/null 2>&1; then
+    ps_script="$(mktemp)"
+    trap 'rm -f "$ps_script"' EXIT
+    cat > "$ps_script" <<'EOF'
+$ClaudeHome = "/tmp/tester/.claude"
+$NotificationStateDir = "$ClaudeHome\notifications\state"
+
+function Get-RateLimitPath {
+    param([string]$Key)
+    $safeKey = ($Key -replace '[^A-Za-z0-9._-]', '_')
+    return Join-Path $NotificationStateDir $safeKey
+}
+
+function Get-LegacyRateLimitPath {
+    param([string]$Key)
+    $safeKey = ($Key -replace '[^A-Za-z0-9._-]', '_')
+    return Join-Path "$ClaudeHome\notifications" $safeKey
+}
+
+$expectedState = "/tmp/tester/.claude/notifications/state/last_notification_claude_demo_idle_prompt"
+$expectedLegacy = "/tmp/tester/.claude/notifications/last_notification_claude_demo_idle_prompt"
+
+if ((Get-RateLimitPath "last_notification_claude_demo_idle_prompt") -ne $expectedState) { exit 1 }
+if ((Get-LegacyRateLimitPath "last_notification_claude_demo_idle_prompt") -ne $expectedLegacy) { exit 1 }
+EOF
+    if ! pwsh -NoProfile -File "$ps_script"; then
+        fail "Windows rate-limit paths should resolve to state and legacy locations"
+    fi
+fi
+
+pass "Windows notifier stores rate-limit state under notifications\\state with legacy fallback"