Unit tests for Splitter

Author: mzinin

src/s2e2/splitter.py

@@ -36,7 +36,13 @@ def __init__(self, type_by_value):
 
         :param type_by_value:
             External function to get token's type by its value.
+
+        :raises:
+            :class:`~TypeError` if the external function is empty.
         """
+        if not type_by_value:
+            raise TypeError('External function to get token type by its value is None')
+
         self.__inside_quotes = False
         self.__current_token = ''
         self.__tokens = []
@@ -52,6 +58,9 @@ def split_into_tokens(self, expression):
 
         :returns:
             List of all found tokens (as :class:`~s2e2.TokenType`).
+
+        :raises:
+            :class:`~s2e2.ExpressionError` if expression contains unknown symbol.
         """
         for symbol in expression:
             self.__process_symbol(symbol)
@@ -65,6 +74,9 @@ def __process_symbol(self, symbol):
 
         :param symbol:
             Symbol of the expression.
+
+        :raises:
+            :class:`~s2e2.ExpressionError` if symbol is unknown.
         """
         if symbol in (COMMA, LEFT_BRACKET, RIGHT_BRACKET):
             self.__process_special_symbol(symbol)
@@ -82,7 +94,7 @@ def __process_special_symbol(self, symbol):
             Special symbol of the expression.
 
         :raises:
-            :class:`~s2e2.ExpressionError` if expression contains unknown symbol.
+            :class:`~s2e2.ExpressionError` if symbol is unknown.
         """
         if self.__inside_quotes:
             self.__add_symbol_to_token(symbol)

test/functions/test_function_now.py

@@ -2,7 +2,6 @@
 from s2e2.functions.function_now import FunctionNow
 
 import datetime
-import pytest
 
 
 class TestFunctionNow:

test/test_splitter.py

@@ -0,0 +1,73 @@
+from s2e2.error import ExpressionError
+from s2e2.splitter import Splitter
+from s2e2.token_type import TokenType
+from s2e2.token import Token
+
+import pytest
+
+
+class TestSplitter:
+
+    def setup(self):
+        self.splitter = Splitter(lambda x: TokenType.ATOM)
+
+
+    def teardown(self):
+        self.splitter = None
+
+
+    def test_positive_new_splitter(self):
+        pass
+
+
+    def test_positive_split_by_comma(self):
+        expression = 'A, B'
+        expected_tokens = [Token(TokenType.ATOM, 'A'),
+                           Token(TokenType.COMMA, ','),
+                           Token(TokenType.ATOM, 'B')]
+
+        actual_tokens = self.splitter.split_into_tokens(expression)
+
+        assert actual_tokens == expected_tokens
+
+
+    def test_positive_split_by_brackets(self):
+        expression = '(A, B)'
+        expected_tokens = [Token(TokenType.LEFT_BRACKET, '('),
+                           Token(TokenType.ATOM, 'A'),
+                           Token(TokenType.COMMA, ','),
+                           Token(TokenType.ATOM, 'B'),
+                           Token(TokenType.RIGHT_BRACKET, ')')]
+
+        actual_tokens = self.splitter.split_into_tokens(expression)
+
+        assert actual_tokens == expected_tokens
+
+
+
+    def test_positive_quoted_atom(self):
+        expression = 'A, "B C"'
+        expected_tokens = [Token(TokenType.ATOM, 'A'),
+                           Token(TokenType.COMMA, ','),
+                           Token(TokenType.ATOM, 'B C')]
+
+        actual_tokens = self.splitter.split_into_tokens(expression)
+
+        assert actual_tokens == expected_tokens
+
+
+    def test_positive_quoted_untrimmed_atom(self):
+        expression = 'A, " B "'
+        expected_tokens = [Token(TokenType.ATOM, 'A'),
+                           Token(TokenType.COMMA, ','),
+                           Token(TokenType.ATOM, ' B ')]
+
+        actual_tokens = self.splitter.split_into_tokens(expression)
+
+        assert actual_tokens == expected_tokens
+
+
+    def test_negative_first_argument_wrong_type(self):
+        with pytest.raises(TypeError) as ex:
+            splitter = Splitter(None)
+        assert 'is None' in str(ex.value)