some example review

Author: 2bndy5

.cspell.config.yml

@@ -4,6 +4,7 @@ words:
   - adafruit
   - addopts
   - armv
+  - ATSAMD
   - baudrate
   - blinka
   - busdevice
@@ -12,9 +13,12 @@ words:
   - circuitpython
   - digitalio
   - Disabl
+  - Dmitry
   - Doherty
+  - Eddystone
   - elif
   - Fals
+  - Grinberg
   - hexlified
   - HHHBB
   - Kbps
@@ -33,3 +37,4 @@ words:
   - setuptools
   - spidev
   - testpaths
+  - urandom

circuitpython_nrf24l01/fake_ble.py

@@ -195,7 +195,7 @@ def __init__(
         self._addr_len = 4  # use only 4 byte address length
         self._tx_address[:4] = b"\x71\x91\x7d\x6b"
         with self:
-            super().open_rx_pipe(0, b"\x71\x91\x7d\x6b\0")
+            super().open_rx_pipe(1, b"\x71\x91\x7d\x6b\0")
         #: The internal queue of received BLE payloads' data.
         self.rx_queue: List[QueueElement] = []
         self.rx_cache: bytearray = bytearray(0)

circuitpython_nrf24l01/rf24.py

@@ -174,7 +174,8 @@ def _reg_read(self, reg: int, command: bool = False) -> int:
             # time.sleep(0.000005)
             spi.write_readinto(self._out, self._in, out_end=len, in_end=len)
         # if command:
-        #     print("SPI command", ("%02X" % reg))
+        #     if reg != 0xFF:
+        #         print("SPI command", ("%02X" % reg))
         # else:
         #     print(
         #         "SPI read", len, "byte from", ("%02X" % reg), ("%02X" % self._in[1])
@@ -210,8 +211,7 @@ def _reg_write(self, reg: int, value: int):
         with self._spi as spi:
             # time.sleep(0.000005)
             spi.write_readinto(self._out, self._in, out_end=buf_len, in_end=buf_len)
-        # if reg != 0xFF:
-        #     print("SPI write 1 byte to", ("%02X" % reg), ("%02X" % value))
+        # print("SPI write 1 byte to", ("%02X" % reg), ("%02X" % value))
 
     @property
     def address_length(self) -> int:

examples/nrf24l01_ack_payload_test.py

@@ -140,9 +140,9 @@ def slave(timeout=6):
             buffer = b"World \0" + bytes([counter[0]])  # build new ACK
             nrf.load_ack(buffer, 1)  # load ACK for next response
 
-    # recommended behavior is to keep in TX mode while idle
-    nrf.listen = False  # put radio in TX mode
-    nrf.flush_tx()  # flush any ACK payloads that remain
+    # recommended behavior is to keep in TX mode when in idle
+    nrf.listen = False  # enter inactive TX mode
+    # entering TX mode (when ACK payloads are enabled) also flushes the TX FIFO
 
 
 def set_role():

examples/nrf24l01_interrupt_test.py

@@ -130,12 +130,13 @@ def slave(timeout=6):  # will listen for 6 seconds before timing out
     while not nrf.fifo(0, 0) and time.monotonic() - start_timer < timeout:
         # if RX FIFO is not full and timeout is not reached, then keep going
         pass
-    nrf.listen = False  # put nRF24L01 in Standby-I mode when idling
+    # recommended behavior is to keep in TX mode when in idle
+    nrf.listen = False  # enter inactive TX mode
+    # entering TX mode (when ACK payloads are enabled) also flushes the TX FIFO
     if not nrf.fifo(False, True):  # if RX FIFO is not empty
         # all 3 payloads received were 5 bytes each, and RX FIFO is full
         # so, fetching 15 bytes from the RX FIFO also flushes RX FIFO
         print("Complete RX FIFO:", nrf.read(15))
-    nrf.flush_tx()  # discard any pending ACK payloads
 
 
 def set_role():

examples/nrf24l01_manual_ack_test.py

@@ -142,7 +142,7 @@ def slave(timeout=6):
             start_timer = time.monotonic()  # reset timeout
 
     # recommended behavior is to keep in TX mode when in idle
-    nrf.listen = False  # put the nRF24L01 in TX mode + Standby-I power state
+    nrf.listen = False  # enter inactive TX mode
 
 
 def set_role():

examples/nrf24l01_simple_test.py

@@ -116,7 +116,7 @@ def slave(timeout=6):
             start = time.monotonic()
 
     # recommended behavior is to keep in TX mode while idle
-    nrf.listen = False  # put the nRF24L01 is in TX mode
+    nrf.listen = False  # enter inactive TX mode
 
 
 def set_role():

examples/nrf24l01_stream_test.py

@@ -154,7 +154,7 @@ def slave(timeout=5):
             start_timer = time.monotonic()  # reset timer on every RX payload
 
     # recommended behavior is to keep in TX mode while idle
-    nrf.listen = False  # put the nRF24L01 is in TX mode
+    nrf.listen = False  # enter inactive TX mode
 
 
 def set_role():